feature #35104 [Messenger] Log sender alias in SendMessageMiddleware (ruudk)

fabpot · fabpot · commit 20bf17f6ad38 · 2020-01-07T20:50:54.000+01:00
This PR was merged into the 5.1-dev branch. Discussion ---------- [Messenger] Log sender alias in SendMessageMiddleware | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | Deprecations? | no | License | MIT This makes it easier to read which sender alias was used. ```diff - Sending message Domain\Event\PaymentFlow\PaymentFlowFailedEvent with Symfony\Component\Messenger\Transport\Doctrine\DoctrineTransport + Sending message Domain\Event\PaymentFlow\PaymentFlowFailedEvent with async sender using Symfony\Component\Messenger\Transport\Doctrine\DoctrineTransport ``` Commits ------- 4e6626c Log sender alias in SendMessageMiddleware
diff --git a/src/Symfony/Component/Messenger/Middleware/SendMessageMiddleware.php b/src/Symfony/Component/Messenger/Middleware/SendMessageMiddleware.php
@@ -65,7 +65,7 @@ public function handle(Envelope $envelope, StackInterface $stack): Envelope
                     $shouldDispatchEvent = false;
                 }
 
-                $this->logger->info('Sending message {class} with {sender}', $context + ['sender' => \get_class($sender)]);
+                $this->logger->info('Sending message {class} with {alias} sender using {sender}', $context + ['alias' => $alias, 'sender' => \get_class($sender)]);
                 $envelope = $sender->send($envelope->with(new SentStamp(\get_class($sender), \is_string($alias) ? $alias : null)));
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,7 @@ public function handle(Envelope $envelope, StackInterface $stack): Envelope`
`65`	`65`	`$shouldDispatchEvent = false;`
`66`	`66`	`}`
`67`	`67`
`68`		`- $this->logger->info('Sending message {class} with {sender}', $context + ['sender' => \get_class($sender)]);`
	`68`	`+ $this->logger->info('Sending message {class} with {alias} sender using {sender}', $context + ['alias' => $alias, 'sender' => \get_class($sender)]);`
`69`	`69`	`$envelope = $sender->send($envelope->with(new SentStamp(\get_class($sender), \is_string($alias) ? $alias : null)));`
`70`	`70`	`}`
`71`	`71`	`}`