8000 minor #23579 [DI] Change "this" to "that" in `findAndSortTaggedServic… · symfony/symfony@1f8cc17 · GitHub
[go: up one dir, main page]
Skip to content

Commit 1f8cc17

Browse files
fabpotfabpot
committed
minor #23579 [DI] Change "this" to "that" in findAndSortTaggedServices doc to reduce confusion (simshaun)
This PR was merged into the 3.2 branch. Discussion ---------- [DI] Change "this" to "that" in `findAndSortTaggedServices` doc to reduce confusion Continuation of PR #23578 which I royally messed up..... | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT | Doc PR | None I know this is extremely minor, but reading the description of this method, I got confused. Wondering if it's just me. Where it says: > The order of additions must be respected for services having the same priority, and knowing that the \SplPriorityQueue class does not respect the FIFO method, we should not use **this** class. Should it not say "we should not use **that** class"? Commits ------- 04b7b04 Change "this" to "that" to avoid confusion
2 parents 30b409a + 04b7b04 commit 1f8cc17

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

‎src/Symfony/Component/DependencyInjection/Compiler/PriorityTaggedServiceTrait.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ trait PriorityTaggedServiceTrait
2626
*
2727
* The order of additions must be respected for services having the same priority,
2828
* and knowing that the \SplPriorityQueue class does not respect the FIFO method,
29-
* we should not use this class.
29+
* we should not use that class.
3030
*
3131
* @see https://bugs.php.net/bug.php?id=53710
3232
* @see https://bugs.php.net/bug.php?id=60926

0 commit comments

Comments
 (0)
0