bug #48112 [HttpFoundation] Compare cookie with null value as empty string in ResponseCookieValueSame (fancyweb)

nicolas-grekas · nicolas-grekas · commit 1ee474f83c93 · 2022-11-05T17:32:34.000+01:00
This PR was merged into the 4.4 branch. Discussion ---------- [HttpFoundation] Compare cookie with null value as empty string in ResponseCookieValueSame | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #48105 | License | MIT | Doc PR | - We already consider `null` as `''` when we "compute" the cookie: https://github.com/symfony/symfony/blob/4d4c411a609ef62dcbdfd6f309deab76a7431135/src/Symfony/Component/HttpFoundation/Cookie.php#L253 So in the related issue, `self::assertResponseCookieValueSame('SOME_COOKIE_NAME', '');` could be used. WDYT `@werwolf666`? Commits ------- 0cc7368 [HttpFoundation] Compare cookie with null value as empty string in ResponseCookieValueSame
diff --git a/src/Symfony/Component/HttpFoundation/Test/Constraint/ResponseCookieValueSame.php b/src/Symfony/Component/HttpFoundation/Test/Constraint/ResponseCookieValueSame.php
@@ -59,7 +59,7 @@ protected function matches($response): bool
             return false;
         }
 
-        return $this->value === $cookie->getValue();
+        return $this->value === (string) $cookie->getValue();
     }
 
     /**
diff --git a/src/Symfony/Component/HttpFoundation/Tests/Test/Constraint/ResponseCookieValueSameTest.php b/src/Symfony/Component/HttpFoundation/Tests/Test/Constraint/ResponseCookieValueSameTest.php
@@ -41,4 +41,12 @@ public function testConstraint()
 
         $this->fail();
     }
+
+    public function testCookieWithNullValueIsComparedAsEmptyString()
+    {
+        $response = new Response();
+        $response->headers->setCookie(Cookie::create('foo', null, 0, '/path'));
+
+        $this->assertTrue((new ResponseCookieValueSame('foo', '', '/path'))->evaluate($response, '', true));
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ protected function matches($response): bool`
`59`	`59`	`return false;`
`60`	`60`	`}`
`61`	`61`
`62`		`- return $this->value === $cookie->getValue();`
	`62`	`+ return $this->value === (string) $cookie->getValue();`
`63`	`63`	`}`
`64`	`64`
`65`	`65`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -41,4 +41,12 @@ public function testConstraint()`
`41`	`41`
`42`	`42`	`$this->fail();`
`43`	`43`	`}`
	`44`	`+`
	`45`	`+ public function testCookieWithNullValueIsComparedAsEmptyString()`
	`46`	`+ {`
	`47`	`+ $response = new Response();`
	`48`	`+ $response->headers->setCookie(Cookie::create('foo', null, 0, '/path'));`
	`49`	`+`
	`50`	`+ $this->assertTrue((new ResponseCookieValueSame('foo', '', '/path'))->evaluate($response, '', true));`
	`51`	`+ }`
`44`	`52`	`}`