feature #45101 [Form] Add inputmode attribute on NumberType (welcoMattic)

fabpot · fabpot · commit 1ebb5d9605ff · 2022-01-22T09:00:26.000+01:00
This PR was merged into the 6.1 branch. Discussion ---------- [Form] Add inputmode attribute on NumberType | Q | A | ------------- | --- | Branch? | 6.1 | Bug fix? | no | New feature? | yes | Deprecations? | no  | Tickets | Fix #45099 | License | MIT | Doc PR | symfony/symfony-docs#...  Quick add of `inputmode` attribute on NumberType, let's discuss about this: - Should it be the default? - Should we add a way to not add the attribute? Thank you @GromNaN for the issue, I had this idea in mind for a long time 😉 Commits ------- f71213b Add inputmode attribute on NumberType
diff --git a/src/Symfony/Component/Form/Extension/Core/Type/NumberType.php b/src/Symfony/Component/Form/Extension/Core/Type/NumberType.php
@@ -47,6 +47,8 @@ public function buildView(FormView $view, FormInterface $form, array $options)
     {
         if ($options['html5']) {
             $view->vars['type'] = 'number';
+        } else {
+            $view->vars['attr']['inputmode'] = 0 === $options['scale'] ? 'numeric' : 'decimal';
         }
     }
 
diff --git a/src/Symfony/Component/Form/Tests/Extension/Core/Type/NumberTypeTest.php b/src/Symfony/Component/Form/Tests/Extension/Core/Type/NumberTypeTest.php
@@ -202,4 +202,36 @@ public function testGroupingNotAllowedWithHtml5Widget()
             'html5' => true,
         ]);
     }
+
+    public function testNumericInputmode()
+    {
+        $form = $this->factory->create(static::TESTED_TYPE, null, [
+            'scale' => 0,
+            'html5' => false,
+        ]);
+        $form->setData(12345.54321);
+
+        $this->assertSame('numeric', $form->createView()->vars['attr']['inputmode']);
+    }
+
+    public function testDecimalInputmode()
+    {
+        $form = $this->factory->create(static::TESTED_TYPE, null, [
+            'scale' => 2,
+            'html5' => false,
+        ]);
+        $form->setData(12345.54321);
+
+        $this->assertSame('decimal', $form->createView()->vars['attr']['inputmode']);
+    }
+
+    public function testNoInputmodeWithHtml5Widget()
+    {
+        $form = $this->factory->create(static::TESTED_TYPE, null, [
+            'html5' => true,
+        ]);
+        $form->setData(12345.54321);
+
+        $this->assertArrayNotHasKey('inputmode', $form->createView()->vars['attr']);
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -47,6 +47,8 @@ public function buildView(FormView $view, FormInterface $form, array $options)`
`47`	`47`	`{`
`48`	`48`	`if ($options['html5']) {`
`49`	`49`	`$view->vars['type'] = 'number';`
	`50`	`+ } else {`
	`51`	`+ $view->vars['attr']['inputmode'] = 0 === $options['scale'] ? 'numeric' : 'decimal';`
`50`	`52`	`}`
`51`	`53`	`}`
`52`	`54`