minor #53176 Fix and add test (OskarStark)

Nyholm · Nyholm · commit 1eab442200f0 · 2023-12-22T07:54:43.000+01:00
This PR was squashed before being merged into the 5.4 branch. Discussion ---------- Fix and add test | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | -- | License | MIT The exception is not raised on `validate` but on instantiating the constraint. I also added a test for an unknown format in an array. Commits ------- 2358719 Fix and add test
diff --git a/src/Symfony/Component/Validator/Tests/Constraints/CssColorValidatorTest.php b/src/Symfony/Component/Validator/Tests/Constraints/CssColorValidatorTest.php
@@ -418,11 +418,22 @@ public function getInvalidHSLA(): array
         return [['hsla(1000, 1000%, 20000%, 999)'], ['hsla(-100, -10%, -2%, 999)'], ['hsla(a, b, c, d)'], ['hsla(a, b%, c%, d)'], ['hsla( 9 99% , 99 9% , 9 %']];
     }
 
-    public function testUnknownFormatsOnValidateTriggerException()
+    /**
+     * @dataProvider getInvalidFormats
+     */
+    public function testUnknownFormatAsStringThrowsException($formats)
     {
         $this->expectException(\InvalidArgumentException::class);
         $this->expectExceptionMessage('The "formats" parameter value is not valid. It must contain one or more of the following values: "hex_long, hex_long_with_alpha, hex_short, hex_short_with_alpha, basic_named_colors, extended_named_colors, system_colors, keywords, rgb, rgba, hsl, hsla".');
-        $constraint = new CssColor('Unknown Format');
-        $this->validator->validate('#F4B907', $constraint);
+
+        new CssColor($formats);
+    }
+
+    public static function getInvalidFormats(): array
+    {
+        return [
+            'as string' => ['Unknown Format'],
+            'as array' => [['Unknown Format']],
+        ];
     }
 }
diff --git a/src/Symfony/Component/Validator/Tests/Constraints/FileValidatorTestCase.php b/src/Symfony/Component/Validator/Tests/Constraints/FileValidatorTestCase.php
@@ -230,11 +230,9 @@ public function testMaxSizeNotExceeded($bytesWritten, $limit)
     public function testInvalidMaxSize()
     {
         $this->expectException(ConstraintDefinitionException::class);
-        $constraint = new File([
+        new File([
             'maxSize' => '1abc',
         ]);
-
-        $this->validator->validate($this->path, $constraint);
     }
 
     public static function provideBinaryFormatTests()

Original file line number	Diff line number	Diff line change
`@@ -230,11 +230,9 @@ public function testMaxSizeNotExceeded($bytesWritten, $limit)`
`230`	`230`	`public function testInvalidMaxSize()`
`231`	`231`	`{`
`232`	`232`	`$this->expectException(ConstraintDefinitionException::class);`
`233`		`- $constraint = new File([`
	`233`	`+ new File([`
`234`	`234`	`'maxSize' => '1abc',`
`235`	`235`	`]);`
`236`		`-`
`237`		`- $this->validator->validate($this->path, $constraint);`
`238`	`236`	`}`
`239`	`237`
`240`	`238`	`public static function provideBinaryFormatTests()`