bug #42835 [Cache] Fix implicit float to int cast (derrabus)

fabpot · fabpot · commit 1e2bf5d526b8 · 2021-09-03T07:06:42.000+02:00
This PR was merged into the 4.4 branch. Discussion ---------- [Cache] Fix implicit float to int cast | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Part of #41552 | License | MIT | Doc PR | N/A Passing a float to a method that expects an integer triggers a deprecation on PHP 8.1 if that implicit float to int cast would mean a loss of precision. This PR fixes such an error in the cache component by making sure an integer is passed. This fixes an error in our 5.3 CI. Commits ------- 93f27d9 Fix implicit float to int cast
diff --git a/src/Symfony/Component/Cache/Adapter/AbstractAdapter.php b/src/Symfony/Component/Cache/Adapter/AbstractAdapter.php
@@ -121,7 +121,7 @@ public static function createSystemCache($namespace, $defaultLifetime, $version,
             return $opcache;
         }
 
-        $apcu = new ApcuAdapter($namespace, (int) $defaultLifetime / 5, $version);
+        $apcu = new ApcuAdapter($namespace, intdiv($defaultLifetime, 5), $version);
         if (null !== $logger) {
             $apcu->setLogger($logger);
         }

Original file line number	Diff line number	Diff line change
`@@ -121,7 +121,7 @@ public static function createSystemCache($namespace, $defaultLifetime, $version,`
`121`	`121`	`return $opcache;`
`122`	`122`	`}`
`123`	`123`
`124`		`- $apcu = new ApcuAdapter($namespace, (int) $defaultLifetime / 5, $version);`
	`124`	`+ $apcu = new ApcuAdapter($namespace, intdiv($defaultLifetime, 5), $version);`
`125`	`125`	`if (null !== $logger) {`
`126`	`126`	`$apcu->setLogger($logger);`
`127`	`127`	`}`