8000 bug #14793 [FrameworkBundle] make `templating.helper.router` service … · symfony/symfony@1dbf67e · GitHub
[go: up one dir, main page]
Skip to content

Commit 1dbf67e

Browse files
fabpotfabpot
committed
bug #14793 [FrameworkBundle] make templating.helper.router service available again for BC reasons (xabbuh)
This PR was merged into the 2.7 branch. Discussion ---------- [FrameworkBundle] make `templating.helper.router` service available again for BC reasons | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #14790 | License | MIT | Doc PR | Commits ------- 95dcfa2 [FrameworkBundle] make `templating.helper.router` service available again for BC reasons
2 parents 09515d6 + 95dcfa2 commit 1dbf67e

File tree

3 files changed

+16
-7
lines changed

3 files changed

+16
-7
lines changed

‎UPGRADE-3.0.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -446,6 +446,15 @@ UPGRADE FROM 2.x to 3.0
446446

447447
* The `RouterApacheDumperCommand` was removed.
448448

449+
* The `templating.helper.router` service was moved to `templating_php.xml`. You
450+
have to ensure that the PHP templating engine is enabled to be able to use it:
451+
452+
```yaml
453+
framework:
454+
templating:
455+
engines: ['php']
456+
```
457+
449458
### HttpKernel
450459
451460
* The `Symfony\Component\HttpKernel\Log\LoggerInterface` has been removed in

‎src/Symfony/Bundle/FrameworkBundle/Resources/config/templating.xml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
<parameter key="templating.loader.chain.class">Symfony\Component\Templating\Loader\ChainLoader</parameter>
1616
<parameter key="templating.finder.class">Symfony\Bundle\FrameworkBundle\CacheWarmer\TemplateFinder</parameter>
1717
<parameter key="templating.helper.assets.class">Symfony\Bundle\FrameworkBundle\Templating\Helper\AssetsHelper</parameter>
18+
<parameter key="templating.helper.router.class">Symfony\Bundle\FrameworkBundle\Templating\Helper\RouterHelper</parameter>
1819
</parameters>
1920

2021
<services>
@@ -61,12 +62,17 @@
6162
<service id="templating.loader" alias="templating.loader.filesystem" />
6263

6364
<!--
64-
This service will be moved to templating_php.xml in version 3.0, it exists here for BC reasons.
65+
The following services will be moved to templating_php.xml in version 3.0, they exist here for BC reasons.
6566
-->
6667
<service id="templating.helper.assets" class="%templating.helper.assets.class%">
6768
<tag name="templating.helper" alias="assets" />
6869
<argument /> <!-- default package -->
6970
<argument type="collection" /> <!-- named packages -->
7071
</service>
72+
73+
<service id="templating.helper.router" class="%templating.helper.router.class%">
74+
<tag name="templating.helper" alias="router" />
75+
<argument type="service" id="router" />
76+
</service>
7177
</services>
7278
</container>

‎src/Symfony/Bundle/FrameworkBundle/Resources/config/templating_php.xml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
<parameter key="templating.engine.php.class">Symfony\Bundle\FrameworkBundle\Templating\PhpEngine</parameter>
99
<parameter key="templating.helper.slots.class">Symfony\Component\Templating\Helper\SlotsHelper</parameter>
1010
<parameter key="templating.helper.actions.class">Symfony\Bundle\FrameworkBundle\Templating\Helper\ActionsHelper</parameter>
11-
<parameter key="templating.helper.router.class">Symfony\Bundle\FrameworkBundle\Templating\Helper\RouterHelper</parameter>
1211
<parameter key="templating.helper.request.class">Symfony\Bundle\FrameworkBundle\Templating\Helper\RequestHelper</parameter>
1312
<parameter key="templating.helper.session.class">Symfony\Bundle\FrameworkBundle\Templating\Helper\SessionHelper</parameter>
1413
<parameter key="templating.helper.code.class">Symfony\Bundle\FrameworkBundle\Templating\Helper\CodeHelper</parameter>
@@ -43,11 +42,6 @@
4342
<argument type="service" id="request_stack" />
4443
</service>
4544

46-
<service id="templating.helper.router" class="%templating.helper.router.class%">
47-
<tag name="templating.helper" alias="router" />
48-
<argument type="service" id="router" />
49-
</service>
50-
5145
<service id="templating.helper.actions" class="%templating.helper.actions.class%">
5246
<tag name="templating.helper" alias="actions" />
5347
<argument type="service" id="fragment.handler" />

0 commit comments

Comments
 (0)
0