bug #18130 [Debug] Replaced logic for detecting filesystem case sensitivity (Dan Blows)

nicolas-grekas · nicolas-grekas · commit 1da85a2b2d99 · 2016-03-13T11:12:58.000+01:00
This PR was squashed before being merged into the 2.7 branch (closes #18130). Discussion ---------- [Debug] Replaced logic for detecting filesystem case sensitivity | Q | A | ------------- | --- | Branch | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | none | License | MIT | Doc PR | none When I cloned the master branch onto a Virtualbox Vagrant OSX El Capitan host, Ubuntu Wily guest, the `Symfony\Component\Debug\Tests\DebugClassLoaderTest::testFileCaseMismatch` failed because 'Failed asserting that exception of type "\RuntimeException" is thrown'. @wouterj confirmed he got the same problem, and it's because Virtualbox shared folders aren't case sensitive, even when the guest is using a case sensitive filesystem. So I've replaced the logic that looked at the name of the operating system. I ran the tests in the following environments: * Virtualbox/Vagrant - OSX Host, Ubuntu guest * Virtualbox/Vagrant - OSX Host, Windows guest * OSX native * Ubuntu native NB - I _didn't_ run it on native Windows (because I don't have easy access to one). Commits ------- 2e81b0a [Debug] Replaced logic for detecting filesystem case sensitivity
diff --git a/src/Symfony/Component/Debug/DebugClassLoader.php b/src/Symfony/Component/Debug/DebugClassLoader.php
@@ -51,7 +51,16 @@ public function __construct($classLoader)
         }
 
         if (!isset(self::$caseCheck)) {
-            self::$caseCheck = false !== stripos(PHP_OS, 'win') ? (false !== stripos(PHP_OS, 'darwin') ? 2 : 1) : 0;
+            if(!file_exists(strtolower(__FILE__))) {
+                // filesystem is case sensitive
+                self::$caseCheck = 0;
+            } elseif(realpath(strtolower(__FILE__)) === __FILE__) {
+                // filesystem is not case sensitive
+                self::$caseCheck = 1;
+            } else {
+                // filesystem is not case sensitive AND realpath() fails to normalize case
+                self::$caseCheck = 2;
+            }
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,16 @@ public function __construct($classLoader)`
`51`	`51`	`}`
`52`	`52`
`53`	`53`	`if (!isset(self::$caseCheck)) {`
`54`		`- self::$caseCheck = false !== stripos(PHP_OS, 'win') ? (false !== stripos(PHP_OS, 'darwin') ? 2 : 1) : 0;`
	`54`	`+ if(!file_exists(strtolower(__FILE__))) {`
	`55`	`+ // filesystem is case sensitive`
	`56`	`+ self::$caseCheck = 0;`
	`57`	`+ } elseif(realpath(strtolower(__FILE__)) === __FILE__) {`
	`58`	`+ // filesystem is not case sensitive`
	`59`	`+ self::$caseCheck = 1;`
	`60`	`+ } else {`
	`61`	`+ // filesystem is not case sensitive AND realpath() fails to normalize case`
	`62`	`+ self::$caseCheck = 2;`
	`63`	`+ }`
`55`	`64`	`}`
`56`	`65`	`}`
`57`	`66`