minor #20322 [DependencyInjection] Remove old code in XML loader (hason)

nicolas-grekas · nicolas-grekas · commit 1c6093e8d5ff · 2016-10-27T11:07:14.000+02:00
This PR was merged into the 3.1 branch. Discussion ---------- [DependencyInjection] Remove old code in XML loader | Q | A | ------------- | --- | Branch? | 3.1 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- d090159 [DependencyInjection] Remove old code in XML loader
diff --git a/src/Symfony/Component/DependencyInjection/Loader/XmlFileLoader.php b/src/Symfony/Component/DependencyInjection/Loader/XmlFileLoader.php
@@ -152,7 +152,7 @@ private function parseDefinition(\DOMElement $service, $file)
 
         foreach (array('class', 'shared', 'public', 'synthetic', 'lazy', 'abstract') as $key) {
             if ($value = $service->getAttribute($key)) {
-                $method = 'set'.str_replace('-', '', $key);
+                $method = 'set'.$key;
                 $definition->$method(XmlUtils::phpize($value));
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -152,7 +152,7 @@ private function parseDefinition(\DOMElement $service, $file)`
`152`	`152`
`153`	`153`	`foreach (array('class', 'shared', 'public', 'synthetic', 'lazy', 'abstract') as $key) {`
`154`	`154`	`if ($value = $service->getAttribute($key)) {`
`155`		`- $method = 'set'.str_replace('-', '', $key);`
	`155`	`+ $method = 'set'.$key;`
`156`	`156`	`$definition->$method(XmlUtils::phpize($value));`
`157`	`157`	`}`
`158`	`158`	`}`