bug #59940 [Cache] Fix missing cache data in profiler (dcmbrs)

nicolas-grekas · nicolas-grekas · commit 1c59de17503e · 2025-03-13T13:01:58.000+01:00
This PR was merged into the 6.4 branch. Discussion ---------- [Cache] Fix missing cache data in profiler | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #59838 | License | MIT There was a problem with the rebase on PR #59841 I added the fix and a test to check it Commits ------- cc505f9 [Cache] fix data collector
diff --git a/src/Symfony/Component/Cache/DataCollector/CacheDataCollector.php b/src/Symfony/Component/Cache/DataCollector/CacheDataCollector.php
@@ -60,6 +60,7 @@ public function lateCollect(): void
 
         $this->data['instances']['statistics'] = $this->calculateStatistics();
         $this->data['total']['statistics'] = $this->calculateTotalStatistics();
+        $this->data['instances']['calls'] = $this->cloneVar($this->data['instances']['calls']);
     }
 
     public function getName(): string
diff --git a/src/Symfony/Component/Cache/Tests/DataCollector/CacheDataCollectorTest.php b/src/Symfony/Component/Cache/Tests/DataCollector/CacheDataCollectorTest.php
@@ -17,6 +17,7 @@
 use Symfony\Component\Cache\DataCollector\CacheDataCollector;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
+use Symfony\Component\VarDumper\Cloner\Data;
 
 class CacheDataCollectorTest extends TestCase
 {
@@ -122,6 +123,7 @@ public function testLateCollect()
         $this->assertEquals($stats[self::INSTANCE_NAME]['hits'], 0, 'hits');
         $this->assertEquals($stats[self::INSTANCE_NAME]['misses'], 1, 'misses');
         $this->assertEquals($stats[self::INSTANCE_NAME]['calls'], 1, 'calls');
+        $this->assertInstanceOf(Data::class, $collector->getCalls());
     }
 
     private function getCacheDataCollectorStatisticsFromEvents(array $traceableAdapterEvents)

Original file line number	Diff line number	Diff line change
`@@ -60,6 +60,7 @@ public function lateCollect(): void`
`60`	`60`
`61`	`61`	`$this->data['instances']['statistics'] = $this->calculateStatistics();`
`62`	`62`	`$this->data['total']['statistics'] = $this->calculateTotalStatistics();`
	`63`	`+ $this->data['instances']['calls'] = $this->cloneVar($this->data['instances']['calls']);`
`63`	`64`	`}`
`64`	`65`
`65`	`66`	`public function getName(): string`
Original file line number	Diff line number	Diff line change
`@@ -17,6 +17,7 @@`
`17`	`17`	`use Symfony\Component\Cache\DataCollector\CacheDataCollector;`
`18`	`18`	`use Symfony\Component\HttpFoundation\Request;`
`19`	`19`	`use Symfony\Component\HttpFoundation\Response;`
	`20`	`+use Symfony\Component\VarDumper\Cloner\Data;`
`20`	`21`
`21`	`22`	`class CacheDataCollectorTest extends TestCase`
`22`	`23`	`{`
`@@ -122,6 +123,7 @@ public function testLateCollect()`
`122`	`123`	`$this->assertEquals($stats[self::INSTANCE_NAME]['hits'], 0, 'hits');`
`123`	`124`	`$this->assertEquals($stats[self::INSTANCE_NAME]['misses'], 1, 'misses');`
`124`	`125`	`$this->assertEquals($stats[self::INSTANCE_NAME]['calls'], 1, 'calls');`
	`126`	`+ $this->assertInstanceOf(Data::class, $collector->getCalls());`
`125`	`127`	`}`
`126`	`128`
`127`	`129`	`private function getCacheDataCollectorStatisticsFromEvents(array $traceableAdapterEvents)`