[Console] Fix catching exception type in QuestionHelper

voronkovich · voronkovich · commit 1c091eb7036c · 2017-06-20T23:21:43.000+03:00
diff --git a/src/Symfony/Component/Console/Helper/QuestionHelper.php b/src/Symfony/Component/Console/Helper/QuestionHelper.php
@@ -111,8 +111,7 @@ public function getName()
      *
      * @return bool|mixed|null|string
      *
-     * @throws \Exception
-     * @throws \RuntimeException
+     * @throws RuntimeException In case the fallback is deactivated and the response cannot be hidden
      */
     public function doAsk(OutputInterface $output, Question $question)
     {
@@ -126,7 +125,7 @@ public function doAsk(OutputInterface $output, Question $question)
             if ($question->isHidden()) {
                 try {
                     $ret = trim($this->getHiddenResponse($output, $inputStream));
-                } catch (\RuntimeException $e) {
+                } catch (RuntimeException $e) {
                     if (!$question->isHiddenFallback()) {
                         throw $e;
                     }

Original file line number	Diff line number	Diff line change
`@@ -111,8 +111,7 @@ public function getName()`
`111`	`111`	`*`
`112`	`112`	`* @return bool\|mixed\|null\|string`
`113`	`113`	`*`
`114`		`- * @throws \Exception`
`115`		`- * @throws \RuntimeException`
	`114`	`+ * @throws RuntimeException In case the fallback is deactivated and the response cannot be hidden`
`116`	`115`	`*/`
`117`	`116`	`public function doAsk(OutputInterface $output, Question $question)`
`118`	`117`	`{`
`@@ -126,7 +125,7 @@ public function doAsk(OutputInterface $output, Question $question)`
`126`	`125`	`if ($question->isHidden()) {`
`127`	`126`	`try {`
`128`	`127`	`$ret = trim($this->getHiddenResponse($output, $inputStream));`
`129`		`- } catch (\RuntimeException $e) {`
	`128`	`+ } catch (RuntimeException $e) {`
`130`	`129`	`if (!$question->isHiddenFallback()) {`
`131`	`130`	`throw $e;`
`132`	`131`	`}`