8000 minor #23852 Made some SecurityBundle tests case-insensitive to prepa… · symfony/symfony@1a5acc9 · GitHub
[go: up one dir, main page]

Skip to content

Commit 1a5acc9

Browse files
author
Robin Chalas
committed
minor #23852 Made some SecurityBundle tests case-insensitive to prepare for future Symfony versions (javiereguiluz)
This PR was squashed before being merged into the 3.4 branch (closes #23852). Discussion ---------- Made some SecurityBundle tests case-insensitive to prepare for future Symfony versions | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This is what @nicolas-grekas [told me to do](#23797 (comment)) to unlock #23797. Commits ------- 9b7750a Made some SecurityBundle tests case-insensitive to prepare for future Symfony versions
2 parents c82ec96 + 9b7750a commit 1a5acc9

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/CompleteConfigurationTest.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,11 @@ public function testFirewalls()
8181
$configs[] = array_values($configDef->getArguments());
8282
}
8383

84+
// the IDs of the services are case sensitive or insensitive depending on
85+
// the Symfony version. Transform them to lowercase to simplify tests.
86+
$configs[0][2] = strtolower($configs[0][2]);
87+
$configs[2][2] = strtolower($configs[2][2]);
88+
8489
$this->assertEquals(array(
8590
array(
8691
'simple',

0 commit comments

Comments
 (0)
0