Fix false-positive deprecation notices for TranslationLoader and WriteCheckSessionHandler

iquito · fabpot · commit 1a427b181dec · 2018-07-19T09:08:14.000+02:00
diff --git a/src/Symfony/Bundle/FrameworkBundle/Translation/TranslationLoader.php b/src/Symfony/Bundle/FrameworkBundle/Translation/TranslationLoader.php
@@ -14,13 +14,16 @@
 use Symfony\Component\Translation\Reader\TranslationReader;
 use Symfony\Component\Translation\MessageCatalogue;
 
-@trigger_error(sprintf('The class "%s" is deprecated since Symfony 3.4 and will be removed in 4.0. Use "%s" instead. ', TranslationLoader::class, TranslationReader::class), E_USER_DEPRECATED);
-
 /**
  * @deprecated since version 3.4 and will be removed in 4.0. Use Symfony\Component\Translation\Reader\TranslationReader instead
  */
 class TranslationLoader extends TranslationReader
 {
+    public function __construct()
+    {
+        @trigger_error(sprintf('The class "%s" is deprecated since Symfony 3.4 and will be removed in 4.0. Use "%s" instead. ', self::class, TranslationReader::class), E_USER_DEPRECATED);
+    }
+
     /**
      * Loads translation messages from a directory to the catalogue.
      *
diff --git a/src/Symfony/Component/HttpFoundation/Session/Storage/Handler/WriteCheckSessionHandler.php b/src/Symfony/Component/HttpFoundation/Session/Storage/Handler/WriteCheckSessionHandler.php
@@ -11,8 +11,6 @@
 
 namespace Symfony\Component\HttpFoundation\Session\Storage\Handler;
 
-@trigger_error(sprintf('The %s class is deprecated since Symfony 3.4 and will be removed in 4.0. Implement `SessionUpdateTimestampHandlerInterface` or extend `AbstractSessionHandler` instead.', WriteCheckSessionHandler::class), E_USER_DEPRECATED);
-
 /**
  * Wraps another SessionHandlerInterface to only write the session when it has been modified.
  *
@@ -31,6 +29,8 @@ class WriteCheckSessionHandler implements \SessionHandlerInterface
 
     public function __construct(\SessionHandlerInterface $wrappedSessionHandler)
     {
+        @trigger_error(sprintf('The %s class is deprecated since Symfony 3.4 and will be removed in 4.0. Implement `SessionUpdateTimestampHandlerInterface` or extend `AbstractSessionHandler` instead.', self::class), E_USER_DEPRECATED);
+
         $this->wrappedSessionHandler = $wrappedSessionHandler;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -11,8 +11,6 @@`
`11`	`11`
`12`	`12`	`namespace Symfony\Component\HttpFoundation\Session\Storage\Handler;`
`13`	`13`
`14`		-@trigger_error(sprintf('The %s class is deprecated since Symfony 3.4 and will be removed in 4.0. Implement `SessionUpdateTimestampHandlerInterface` or extend `AbstractSessionHandler` instead.', WriteCheckSessionHandler::class), E_USER_DEPRECATED);
`15`		`-`
`16`	`14`	`/**`
`17`	`15`	`* Wraps another SessionHandlerInterface to only write the session when it has been modified.`
`18`	`16`	`*`
`@@ -31,6 +29,8 @@ class WriteCheckSessionHandler implements \SessionHandlerInterface`
`31`	`29`
`32`	`30`	`public function __construct(\SessionHandlerInterface $wrappedSessionHandler)`
`33`	`31`	`{`
	`32`	+ @trigger_error(sprintf('The %s class is deprecated since Symfony 3.4 and will be removed in 4.0. Implement `SessionUpdateTimestampHandlerInterface` or extend `AbstractSessionHandler` instead.', self::class), E_USER_DEPRECATED);
	`33`	`+`
`34`	`34`	`$this->wrappedSessionHandler = $wrappedSessionHandler;`
`35`	`35`	`}`
`36`	`36`