minor #57657 [Messenger] [SQS] Allow to pass sslmode as an option (spuf)

nicolas-grekas · nicolas-grekas · commit 1a16ebc32598 · 2024-07-10T17:23:17.000+02:00
This PR was merged into the 7.2 branch. Discussion ---------- [Messenger] [SQS] Allow to pass `sslmode` as an option | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT This is a minor. There is an option "sslmode" that is documented as an option but can be passed only in dsn query string. Commits ------- 1303cd1 [Messenger][SQS] Allow to pass sslmode as an option
diff --git a/src/Symfony/Component/Messenger/Bridge/AmazonSqs/Transport/Connection.php b/src/Symfony/Component/Messenger/Bridge/AmazonSqs/Transport/Connection.php
@@ -147,7 +147,7 @@ public static function fromDsn(#[\SensitiveParameter] string $dsn, array $option
         unset($query['region']);
 
         if ('default' !== ($params['host'] ?? 'default')) {
-            $clientConfiguration['endpoint'] = \sprintf('%s://%s%s', ($query['sslmode'] ?? null) === 'disable' ? 'http' : 'https', $params['host'], ($params['port'] ?? null) ? ':'.$params['port'] : '');
+            $clientConfiguration['endpoint'] = \sprintf('%s://%s%s', ($options['sslmode'] ?? null) === 'disable' ? 'http' : 'https', $params['host'], ($params['port'] ?? null) ? ':'.$params['port'] : '');
             if (preg_match(';^sqs\.([^\.]++)\.amazonaws\.com$;', $params['host'], $matches)) {
                 $clientConfiguration['region'] = $matches[1];
             }

Original file line number	Diff line number	Diff line change
`@@ -147,7 +147,7 @@ public static function fromDsn(#[\SensitiveParameter] string $dsn, array $option`
`147`	`147`	`unset($query['region']);`
`148`	`148`
`149`	`149`	`if ('default' !== ($params['host'] ?? 'default')) {`
`150`		`- $clientConfiguration['endpoint'] = \sprintf('%s://%s%s', ($query['sslmode'] ?? null) === 'disable' ? 'http' : 'https', $params['host'], ($params['port'] ?? null) ? ':'.$params['port'] : '');`
	`150`	`+ $clientConfiguration['endpoint'] = \sprintf('%s://%s%s', ($options['sslmode'] ?? null) === 'disable' ? 'http' : 'https', $params['host'], ($params['port'] ?? null) ? ':'.$params['port'] : '');`
`151`	`151`	`if (preg_match(';^sqs\.([^\.]++)\.amazonaws\.com$;', $params['host'], $matches)) {`
`152`	`152`	`$clientConfiguration['region'] = $matches[1];`
`153`	`153`	`}`