[TranslationUpdateCommand] fixed undefined resultMessage var.

aitboudad · aitboudad · commit 1999e89e7c21 · 2015-12-10T19:14:16.000Z
diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/TranslationUpdateCommand.php b/src/Symfony/Bundle/FrameworkBundle/Command/TranslationUpdateCommand.php
@@ -150,6 +150,8 @@ protected function execute(InputInterface $input, OutputInterface $output)
             return;
         }
 
+        $resultMessage = 'Translation files were successfully updated.';
+
         // show compiled list of messages
         if (true === $input->getOption('dump-messages')) {
             $extractedMessagesCount = 0;
@@ -205,8 +207,6 @@ protected function execute(InputInterface $input, OutputInterface $output)
 
             if (true === $input->getOption('dump-messages')) {
                 $resultMessage .= ' and translation files were updated.';
-            } else {
-                $resultMessage = 'Translation files were successfully updated.';
             }
         }
 
diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/Command/TranslationUpdateCommandTest.php b/src/Symfony/Bundle/FrameworkBundle/Tests/Command/TranslationUpdateCommandTest.php
@@ -28,6 +28,14 @@ public function testDumpMessagesAndClean()
         $tester = $this->createCommandTester($this->getContainer(array('foo' => 'foo')));
         $tester->execute(array('command' => 'translation:update', 'locale' => 'en', 'bundle' => 'foo', '--dump-messages' => true, '--clean' => true));
         $this->assertRegExp('/foo/', $tester->getDisplay());
+        $this->assertRegExp('/2 messages were successfully extracted/', $tester->getDisplay());
+    }
+
+    public function testWriteMessages()
+    {
+        $tester = $this->createCommandTester($this->getContainer(array('foo' => 'foo')));
+        $tester->execute(array('command' => 'translation:update', 'locale' => 'en', 'bundle' => 'foo', '--force' => true));
+        $this->assertRegExp('/Translation files were successfully updated./', $tester->getDisplay());
     }
 
     protected function setUp()

Original file line number	Diff line number	Diff line change
`@@ -150,6 +150,8 @@ protected function execute(InputInterface $input, OutputInterface $output)`
`150`	`150`	`return;`
`151`	`151`	`}`
`152`	`152`
	`153`	`+ $resultMessage = 'Translation files were successfully updated.';`
	`154`	`+`
`153`	`155`	`// show compiled list of messages`
`154`	`156`	`if (true === $input->getOption('dump-messages')) {`
`155`	`157`	`$extractedMessagesCount = 0;`
`@@ -205,8 +207,6 @@ protected function execute(InputInterface $input, OutputInterface $output)`
`205`	`207`
`206`	`208`	`if (true === $input->getOption('dump-messages')) {`
`207`	`209`	`$resultMessage .= ' and translation files were updated.';`
`208`		`- } else {`
`209`		`- $resultMessage = 'Translation files were successfully updated.';`
`210`	`210`	`}`
`211`	`211`	`}`
`212`	`212`