minor #46727 [DoctrineBridge] Fix value type for simple_array (Gigino Chianese)

nicolas-grekas · nicolas-grekas · commit 189e7a46f375 · 2022-06-21T09:16:04.000+02:00
This PR was merged into the 5.4 branch. Discussion ---------- [DoctrineBridge] Fix value type for simple_array | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | Fix for wrong collection value type on `simple_array` after merging the type guessing changes (#46676) into 5.4 branch. Commits ------- 6375990 [DoctrineBridge] Fix value type for simple_array
diff --git a/src/Symfony/Bridge/Doctrine/PropertyInfo/DoctrineExtractor.php b/src/Symfony/Bridge/Doctrine/PropertyInfo/DoctrineExtractor.php
@@ -180,7 +180,7 @@ public function getTypes(string $class, string $property, array $context = [])
                             return [new Type(Type::BUILTIN_TYPE_ARRAY, $nullable, null, true)];
 
                         case Types::SIMPLE_ARRAY:
-                            return [new Type(Type::BUILTIN_TYPE_ARRAY, $nullable, null, true, new Type(Type::BUILTIN_TYPE_INT), new Type(Type::BUILTIN_TYPE_STRING))];
+                            return [new Type(Type::BUILTIN_TYPE_ARRAY, $nullable, null, true, new Type(Type::BUILTIN_TYPE_INT), $enumType ?? new Type(Type::BUILTIN_TYPE_STRING))];
                     }
                     break;
                 case Type::BUILTIN_TYPE_INT:

Original file line number	Diff line number	Diff line change
`@@ -180,7 +180,7 @@ public function getTypes(string $class, string $property, array $context = [])`
`180`	`180`	`return [new Type(Type::BUILTIN_TYPE_ARRAY, $nullable, null, true)];`
`181`	`181`
`182`	`182`	`case Types::SIMPLE_ARRAY:`
`183`		`- return [new Type(Type::BUILTIN_TYPE_ARRAY, $nullable, null, true, new Type(Type::BUILTIN_TYPE_INT), new Type(Type::BUILTIN_TYPE_STRING))];`
	`183`	`+ return [new Type(Type::BUILTIN_TYPE_ARRAY, $nullable, null, true, new Type(Type::BUILTIN_TYPE_INT), $enumType ?? new Type(Type::BUILTIN_TYPE_STRING))];`
`184`	`184`	`}`
`185`	`185`	`break;`
`186`	`186`	`case Type::BUILTIN_TYPE_INT:`