8000 minor #29415 [WebProfilerBundle] Split form field heading (ro0NL) · symfony/symfony@17874f6 · GitHub
[go: up one dir, main page]

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 17874f6

Browse files
minor #29415 [WebProfilerBundle] Split form field heading (ro0NL)
This PR was merged into the 3.4 branch. Discussion ---------- [WebProfilerBundle] Split form field heading | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> By default the data class 9/10 breaks inline, making it harder to read. This fixes it. Before ![image](https://user-images.githubusercontent.com/1047696/49332204-02cbf800-f5a9-11e8-8565-f0f084fa76dd.png) After ![image](https://user-images.githubusercontent.com/1047696/49332202-f47ddc00-f5a8-11e8-8a97-80f002c9bfc2.png) Commits ------- 3855d5a [WebProfilerBundle] Split form field heading
2 parents 46eee7e + 3855d5a commit 17874f6

File tree

1 file changed

+10
-3
lines changed
  • src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector

1 file changed

+10
-3
lines changed

src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/form.html.twig

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -177,6 +177,12 @@
177177
color: inherit;
178178
text-decoration: inherit;
179179
}
180+
h2 + h3.form-data-type {
181+
margin-top: 0;
182+
}
183+
h3.form-data-type + h3 {
184+
margin-top: 1em;
185+
}
180186
</style>
181187
{% endblock %}
182188

@@ -455,9 +461,10 @@
455461
{% macro form_tree_details(name, data, forms_by_hash, show) %}
456462
{% import _self as tree %}
457463
<div class="tree-details{% if not show|default(false) %} hidden{% endif %}" {% if data.id is defined %}id="{{ data.id }}-details"{% endif %}>
458-
<h2 class="dump-inline">
459-
{{ name|default('(no name)') }} {% if data.type_class is defined %}({{ profiler_dump(data.type_class) }}){% endif %}
460-
</h2>
464+
<h2>{{ name|default('(no name)') }}</h2>
465+
{% if data.type_class is defined %}
466+
<h3 class="dump-inline form-data-type">{{ profiler_dump(data.type_class) }}</h3>
467+
{% endif %}
461468

462469
{% if data.errors is defined and data.errors|length > 0 %}
463470
<div class="errors">

0 commit comments

Comments
 (0)
0