[LokaliseBridge] Fix push command --delete-missing options when there are no missing messages

rwionczek · rwionczek · commit 176909452d25 · 2022-08-26T00:43:57.000+02:00
diff --git a/src/Symfony/Component/Translation/Bridge/Lokalise/LokaliseProvider.php b/src/Symfony/Component/Translation/Bridge/Lokalise/LokaliseProvider.php
@@ -124,6 +124,11 @@ public function delete(TranslatorBagInterface $translatorBag): void
             foreach (array_keys($catalogue->all($domain)) as $key) {
                 $keysToDelete[] = $key;
             }
+
+            if (!$keysToDelete) {
+                continue;
+            }
+
             $keysIds += $this->getKeysIds($keysToDelete, $domain);
         }
 
diff --git a/src/Symfony/Component/Translation/Bridge/Lokalise/Tests/LokaliseProviderTest.php b/src/Symfony/Component/Translation/Bridge/Lokalise/Tests/LokaliseProviderTest.php
@@ -699,10 +699,12 @@ public function testDeleteProcess()
         $translatorBag->addCatalogue(new MessageCatalogue('en', [
             'messages' => ['a' => 'trans_en_a'],
             'validators' => ['post.num_comments' => '{count, plural, one {# comment} other {# comments}}'],
+            'domain_without_missing_messages' => [],
         ]));
         $translatorBag->addCatalogue(new MessageCatalogue('fr', [
             'messages' => ['a' => 'trans_fr_a'],
             'validators' => ['post.num_comments' => '{count, plural, one {# commentaire} other {# commentaires}}'],
+            'domain_without_missing_messages' => [],
         ]));
 
         $provider = $this->createProvider(

Original file line number	Diff line number	Diff line change
`@@ -124,6 +124,11 @@ public function delete(TranslatorBagInterface $translatorBag): void`
`124`	`124`	`foreach (array_keys($catalogue->all($domain)) as $key) {`
`125`	`125`	`$keysToDelete[] = $key;`
`126`	`126`	`}`
	`127`	`+`
	`128`	`+ if (!$keysToDelete) {`
	`129`	`+ continue;`
	`130`	`+ }`
	`131`	`+`
`127`	`132`	`$keysIds += $this->getKeysIds($keysToDelete, $domain);`
`128`	`133`	`}`
`129`	`134`