[HttpKernel] The Cache-Control header should only contain either public, private or no-cache

jakzal · jakzal · commit 17149d62b914 · 2015-12-30T13:37:28.000+01:00
diff --git a/src/Symfony/Component/HttpKernel/Tests/HttpCache/HttpCacheTest.php b/src/Symfony/Component/HttpKernel/Tests/HttpCache/HttpCacheTest.php
@@ -1107,7 +1107,8 @@ public function testEsiCacheForceValidation()
         $this->assertEquals('Hello World! My name is Bobby.', $this->response->getContent());
         $this->assertNull($this->response->getTtl());
         $this->assertTrue($this->response->mustRevalidate());
-        $this->assertTrue($this->response->headers->hasCacheControlDirective('private'));
+        $this->assertFalse($this->response->headers->hasCacheControlDirective('private'));
+        $this->assertTrue($this->response->headers->hasCacheControlDirective('must-revalidate'));
         $this->assertTrue($this->response->headers->hasCacheControlDirective('no-cache'));
     }
 

Original file line number	Diff line number	Diff line change
`@@ -1107,7 +1107,8 @@ public function testEsiCacheForceValidation()`
`1107`	`1107`	`$this->assertEquals('Hello World! My name is Bobby.', $this->response->getContent());`
`1108`	`1108`	`$this->assertNull($this->response->getTtl());`
`1109`	`1109`	`$this->assertTrue($this->response->mustRevalidate());`
`1110`		`- $this->assertTrue($this->response->headers->hasCacheControlDirective('private'));`
	`1110`	`+ $this->assertFalse($this->response->headers->hasCacheControlDirective('private'));`
	`1111`	`+ $this->assertTrue($this->response->headers->hasCacheControlDirective('must-revalidate'));`
`1111`	`1112`	`$this->assertTrue($this->response->headers->hasCacheControlDirective('no-cache'));`
`1112`	`1113`	`}`
`1113`	`1114`