[Intl] make type-hinted arguments nullable

xabbuh · xabbuh · commit 16ebeb395f4f · 2019-01-05T09:55:10.000+01:00
diff --git a/src/Symfony/Component/Intl/DateFormatter/IntlDateFormatter.php b/src/Symfony/Component/Intl/DateFormatter/IntlDateFormatter.php
@@ -132,7 +132,7 @@ class IntlDateFormatter
      * @throws MethodArgumentValueNotImplementedException When $locale different than "en" or null is passed
      * @throws MethodArgumentValueNotImplementedException When $calendar different than GREGORIAN is passed
      */
-    public function __construct(?string $locale, int $datetype, int $timetype, $timezone = null, ?int $calendar = self::GREGORIAN, string $pattern = null)
+    public function __construct(?string $locale, ?int $datetype, ?int $timetype, $timezone = null, ?int $calendar = self::GREGORIAN, string $pattern = null)
     {
         if ('en' !== $locale && null !== $locale) {
             throw new MethodArgumentValueNotImplementedException(__METHOD__, 'locale', $locale, 'Only the locale "en" is supported');

Original file line number	Diff line number	Diff line change
`@@ -132,7 +132,7 @@ class IntlDateFormatter`
`132`	`132`	`* @throws MethodArgumentValueNotImplementedException When $locale different than "en" or null is passed`
`133`	`133`	`* @throws MethodArgumentValueNotImplementedException When $calendar different than GREGORIAN is passed`
`134`	`134`	`*/`
`135`		`- public function __construct(?string $locale, int $datetype, int $timetype, $timezone = null, ?int $calendar = self::GREGORIAN, string $pattern = null)`
	`135`	`+ public function __construct(?string $locale, ?int $datetype, ?int $timetype, $timezone = null, ?int $calendar = self::GREGORIAN, string $pattern = null)`
`136`	`136`	`{`
`137`	`137`	`if ('en' !== $locale && null !== $locale) {`
`138`	`138`	`throw new MethodArgumentValueNotImplementedException(__METHOD__, 'locale', $locale, 'Only the locale "en" is supported');`