8000 feature #58386 [WebProfilerBundle] Update the contents of the Config … · symfony/symfony@1687641 · GitHub
[go: up one dir, main page]

Skip to content

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 1687641

Browse files
committed
feature #58386 [WebProfilerBundle] Update the contents of the Config panel (javiereguiluz)
This PR was merged into the 7.2 branch. Discussion ---------- [WebProfilerBundle] Update the contents of the Config panel | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | yes | Deprecations? | no | Issues | -lain below instead --> | License | MIT Similar to #58366 and #58380, this fixes an accessibility issue of the Web Debug Toolbar: ``` The "title" attribute can't be used in non-interactive elements ``` It now looks like this: ![image](https://github.com/user-attachments/assets/dff8d754-9661-40a7-81f9-5734f0ab36aa) Commits ------- 9f8d2f9 [WebProfilerBundle] Update the contents of the Config panel
2 parents 2cfb1a1 + 9f8d2f9 commit 1687641

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/config.html.twig

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,14 @@
7272
{% endset %}
7373

7474
{% set text %}
75+
{% if symfony_version_status %}
76+
<div class="sf-toolbar-info-group">
77+
<div class="sf-toolbar-info-piece">
78+
<span>{{ symfony_version_status }}</span>
79+
</div>
80+
</div>
81+
{% endif %}
82+
7583
<div class="sf-toolbar-info-group">
7684
<div class="sf-toolbar-info-piece">
7785
<b>Profiler token</b>
@@ -149,7 +157,7 @@
149157
</div>
150158
{% endset %}
151159

152-
{{ include('@WebProfiler/Profiler/toolbar_item.html.twig', { link: true, name: 'config', status: block_status, additional_classes: 'sf-toolbar-block-right', block_attrs: 'title="' ~ symfony_version_status ~ '"' }) }}
160+
{{ include('@WebProfiler/Profiler/toolbar_item.html.twig', { link: true, name: 'config', status: block_status, additional_classes: 'sf-toolbar-block-right' }) }}
153161
{% endblock %}
154162

155163
{% block menu %}

0 commit comments

Comments
 (0)
0