bug #43137 [FrameworkBundle] Avoid secrets:decrypt-to-local command to fail (noniagriconomie)

nicolas-grekas · nicolas-grekas · commit 1636a266bc41 · 2021-09-24T18:07:44.000+02:00
This PR was merged into the 4.4 branch. Discussion ---------- [FrameworkBundle] Avoid secrets:decrypt-to-local command to fail | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #42038 | License | MIT | Doc PR | . Small PR to fix this issue I encounter as well For now I've not opted for solutions exposed in the issue, please discuss here Also, I kept the vault continuing instead of stopping the command in case of null value Thank you, Commits ------- b52451c [FrameworkBundle] Avoid secrets:decrypt-to-local command to fail
diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/SecretsDecryptToLocalCommand.php b/src/Symfony/Bundle/FrameworkBundle/Command/SecretsDecryptToLocalCommand.php
@@ -77,9 +77,8 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 
         foreach ($secrets as $k => $v) {
             if (null === $v) {
-                $io->error($this->vault->getLastMessage());
-
-                return 1;
+                $io->error($this->vault->getLastMessage() ?? sprintf('Secret "%s" has been skipped as there was an error reading it.', $k));
+                continue;
             }
 
             $this->localVault->seal($k, $v);
