minor #19200 [VarDumper] Allow full collapsing of HTML dumps (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit 160185c3d0bc · 2016-06-28T08:16:50.000+02:00
This PR was merged into the 3.2-dev branch. Discussion ---------- [VarDumper] Allow full collapsing of HTML dumps | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #16741 | License | MIT | Doc PR | - Because I missed the feature request in #16741 to allow full collapsing. Commits ------- 633989b [VarDumper] Allow full collapsing of HTML dumps
diff --git a/src/Symfony/Component/VarDumper/Dumper/HtmlDumper.php b/src/Symfony/Component/VarDumper/Dumper/HtmlDumper.php
@@ -294,11 +294,11 @@ function isCtrlKey(e) {
             x = 1;
             if ('sf-dump' != elt.parentNode.className) {
                 x += elt.parentNode.getAttribute('data-depth')/1;
-                if (x > options.maxDepth) {
-                    toggle(a);
-                }
             }
             elt.setAttribute('data-depth', x);
+            if (x > options.maxDepth) {
+                toggle(a);
+            }
         } else if ('sf-dump-ref' == elt.className && (a = elt.getAttribute('href'))) {
             a = a.substr(1);
             elt.className += ' '+a;
