8000 [FrameworkBundle][RateLimiter] deprecate `RateLimiterFactory` alias · symfony/symfony@159e00c · GitHub
[go: up one dir, main page]
Skip to content

Commit 159e00c

Browse files
kbondkbond
committed
[FrameworkBundle][RateLimiter] deprecate RateLimiterFactory alias
1 parent 17445a3 commit 159e00c

File tree

3 files changed

+4
-1
lines changed

3 files changed

+4
-1
lines changed

‎UPGRADE-7.3.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@ FrameworkBundle
5959
because its default value will change in version 8.0
6060
* Deprecate the `--show-arguments` option of the `container:debug` command, as arguments are now always shown
6161
* Deprecate the `framework.validation.cache` config option
62+
* Deprecate the `RateLimiterFactory` alias, use `RateLimiterFactoryInterface` instead
6263
* Deprecate setting the `framework.profiler.collect_serializer_data` config option to `false`
6364

6465
When set to `true`, normalizers must be injected using the `NormalizerInterface`, and not using any concrete implementation.

‎src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ CHANGELOG
2323
the `#[AsController]` attribute is no longer required
2424
* Deprecate setting the `framework.profiler.collect_serializer_data` config option to `false`
2525
* Set `framework.rate_limiter.limiters.*.lock_factory` to `auto` by default
26+
* Deprecate `RateLimiterFactory` alias
2627

2728
7.2
2829
---

‎src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3266,10 +3266,11 @@ private function registerRateLimiterConfiguration(array $config, ContainerBuilde
32663266
$limiterConfig['id'] = $name;
32673267
$limiter->replaceArgument(0, $limiterConfig);
32683268

3269-
$container->registerAliasForArgument($limiterId, RateLimiterFactory::class, $name.'.limiter');
3269+
$factoryAlias = $container->registerAliasForArgument($limiterId, RateLimiterFactory::class, $name.'.limiter');
32703270

32713271
if (interface_exists(RateLimiterFactoryInterface::class)) {
32723272
$container->registerAliasForArgument($limiterId, RateLimiterFactoryInterface::class, $name.'.limiter');
3273+
$factoryAlias->setDeprecated('symfony/dependency-injection', '7.3', 'The "%alias_id%" service alias is deprecated and will be removed in 8.0.').\sprintf(' You should use "%s %s.limiter" instead.', RateLimiterFactoryInterface::class, $name);
32733274
}
32743275
}
32753276
}

0 commit comments

Comments
 (0)
0