bug #29527 [TwigBridge][Form] Prevent multiple rendering of form collection prototypes (Shoplifter)

nicolas-grekas · nicolas-grekas · commit 153220a932c8 · 2018-12-12T18:34:38.000+01:00
This PR was merged into the 3.4 branch. Discussion ---------- [TwigBridge][Form] Prevent multiple rendering of form collection prototypes | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no  | BC breaks? | no  | Deprecations? | no  | Tests pass? | yes  | Fixed tickets | #29489  | License | MIT prevents attemt to render of prototype in CollectionType when it has been rendered already. (see [Deprecated calling FormRenderer::searchAndRenderBlock for fields which were already rendered.](https://github.com/symfony/symfony/blob/master/UPGRADE-4.2.md#form)) Commits ------- ffd2722 [TwigBridge][Form] Prevent multiple rendering of form collection prototypes
diff --git a/src/Symfony/Bridge/Twig/Resources/views/Form/form_div_layout.html.twig b/src/Symfony/Bridge/Twig/Resources/views/Form/form_div_layout.html.twig
@@ -24,7 +24,7 @@
 {%- endblock form_widget_compound -%}
 
 {%- block collection_widget -%}
-    {% if prototype is defined %}
+    {% if prototype is defined and not prototype.rendered %}
         {%- set attr = attr|merge({'data-prototype': form_row(prototype) }) -%}
     {% endif %}
     {{- block('form_widget') -}}
