minor #35880 [5.0] Remove some unused variables (fancyweb)

fabpot · fabpot · commit 15297b1409dc · 2020-02-27T07:04:32.000+01:00
This PR was merged into the 5.0 branch. Discussion ---------- [5.0] Remove some unused variables | Q | A | ------------- | --- | Branch? | 5.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Some cleanup. Commits ------- 1f953e4 [5.0] Remove some unused variables
diff --git a/src/Symfony/Component/HttpClient/Internal/HttplugWaitLoop.php b/src/Symfony/Component/HttpClient/Internal/HttplugWaitLoop.php
@@ -72,7 +72,7 @@ public function wait(?ResponseInterface $pendingResponse, float $maxDuration = n
                         goto check_duration;
                     }
 
-                    if ([$request, $promise] = $this->promisePool[$response] ?? null) {
+                    if ([, $promise] = $this->promisePool[$response] ?? null) {
                         unset($this->promisePool[$response]);
                         $promise->resolve($this->createPsr7Response($response, true));
                     }
diff --git a/src/Symfony/Component/String/UnicodeString.php b/src/Symfony/Component/String/UnicodeString.php
@@ -243,7 +243,7 @@ public function replace(string $from, string $to): AbstractString
                 $tail = substr($tail, \strlen($slice) + \strlen($from));
             }
 
-            $str->string = $result .= $tail;
+            $str->string = $result.$tail;
             normalizer_is_normalized($str->string) ?: $str->string = normalizer_normalize($str->string);
 
             if (false === $str->string) {
diff --git a/src/Symfony/Component/VarDumper/Cloner/VarCloner.php b/src/Symfony/Component/VarDumper/Cloner/VarCloner.php
@@ -28,7 +28,6 @@ protected function doClone($var)
         $pos = 0;                       // Number of cloned items past the minimum depth
         $refsCounter = 0;               // Hard references counter
         $queue = [[$var]];    // This breadth-first queue is the return value
-        $indexedArrays = [];       // Map of queue indexes that hold numerically indexed arrays
         $hardRefs = [];            // Map of original zval ids to stub objects
         $objRefs = [];             // Map of original object handles to their stub object counterpart
         $objects = [];             // Keep a ref to objects to ensure their handle cannot be reused while cloning

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ public function wait(?ResponseInterface $pendingResponse, float $maxDuration = n`
`72`	`72`	`goto check_duration;`
`73`	`73`	`}`
`74`	`74`
`75`		`- if ([$request, $promise] = $this->promisePool[$response] ?? null) {`
	`75`	`+ if ([, $promise] = $this->promisePool[$response] ?? null) {`
`76`	`76`	`unset($this->promisePool[$response]);`
`77`	`77`	`$promise->resolve($this->createPsr7Response($response, true));`
`78`	`78`	`}`
Original file line number	Diff line number	Diff line change
`@@ -243,7 +243,7 @@ public function replace(string $from, string $to): AbstractString`
`243`	`243`	`$tail = substr($tail, \strlen($slice) + \strlen($from));`
`244`	`244`	`}`
`245`	`245`
`246`		`- $str->string = $result .= $tail;`
	`246`	`+ $str->string = $result.$tail;`
`247`	`247`	`normalizer_is_normalized($str->string) ?: $str->string = normalizer_normalize($str->string);`
`248`	`248`
`249`	`249`	`if (false === $str->string) {`