top-level anonymous services must be public

xabbuh · xabbuh · commit 13a47c3c6ddd · 2016-05-04T22:01:55.000+02:00
diff --git a/src/Symfony/Component/DependencyInjection/Loader/XmlFileLoader.php b/src/Symfony/Component/DependencyInjection/Loader/XmlFileLoader.php
@@ -237,6 +237,9 @@ private function processAnonymousServices(SimpleXMLElement $xml, $file)
 
                 $definitions[(string) $node['id']] = array($node->service, $file, false);
                 $node->service['id'] = (string) $node['id'];
+
+                // anonymous services are always private
+                $node->service['public'] = false;
             }
         }
 
@@ -254,9 +257,6 @@ private function processAnonymousServices(SimpleXMLElement $xml, $file)
         // resolve definitions
         krsort($definitions);
         foreach ($definitions as $id => $def) {
-            // anonymous services are always private
-            $def[0]['public'] = false;
-
             $this->parseDefinition($id, $def[0], $def[1]);
 
             $oNode = dom_import_simplexml($def[0]);
diff --git a/src/Symfony/Component/DependencyInjection/Tests/Loader/XmlFileLoaderTest.php b/src/Symfony/Component/DependencyInjection/Tests/Loader/XmlFileLoaderTest.php
@@ -158,7 +158,7 @@ public function testLoadAnonymousServices()
             $service = $container->getDefinition($id);
         }
         $this->assertEquals('BizClass', $service->getClass(), '->load() uses the same configuration as for the anonymous ones');
-        $this->assertFalse($service->isPublic());
+        $this->assertTrue($service->isPublic());
 
         // anonymous services are shared when using decoration definitions
         $container->compile();

Original file line number	Diff line number	Diff line change
`@@ -158,7 +158,7 @@ public function testLoadAnonymousServices()`
`158`	`158`	`$service = $container->getDefinition($id);`
`159`	`159`	`}`
`160`	`160`	`$this->assertEquals('BizClass', $service->getClass(), '->load() uses the same configuration as for the anonymous ones');`
`161`		`- $this->assertFalse($service->isPublic());`
	`161`	`+ $this->assertTrue($service->isPublic());`
`162`	`162`
`163`	`163`	`// anonymous services are shared when using decoration definitions`
`164`	`164`	`$container->compile();`