8000 [VarDumper] Fixed file links leave blank pages when ide is configured · symfony/symfony@138cd09 · GitHub
[go: up one dir, main page]
Skip to content

Commit 138cd09

Browse files
antalaronantalaron
committed
[VarDumper] Fixed file links leave blank pages when ide is configured
1 parent b783602 commit 138cd09

File tree

2 files changed

+26
-4
lines changed

2 files changed

+26
-4
lines changed

‎src/Symfony/Component/VarDumper/Dumper/HtmlDumper.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -828,7 +828,8 @@ protected function style($style, $value, $attr = array())
828828
$attr['href'] = $href;
829829
}
830830
if (isset($attr['href'])) {
831-
$v = sprintf('<a href="%s" target="_blank" rel="noopener noreferrer">%s</a>', esc($this->utf8Encode($attr['href'])), $v);
831+
$target = isset($attr['file']) ? '' : ' target="_blank"';
832+
$v = sprintf('<a href="%s"%s rel="noopener noreferrer">%s</a>', esc($this->utf8Encode($attr['href'])), $target, $v);
832833
}
833834
if (isset($attr['lang'])) {
834835
$v = sprintf('<code class="%s">%s</code>', esc($attr['lang']), $v);

‎src/Symfony/Component/VarDumper/Tests/Caster/StubCasterTest.php

Lines changed: 24 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,28 @@ public function testLinkStub()
100100

101101
$expectedDump = <<<'EODUMP'
102102
<foo></foo><bar><span class=sf-dump-note>array:1</span> [<samp>
103-
<span class=sf-dump-index>0</span> => "<a href="%sStubCasterTest.php:0" target="_blank" rel="noopener noreferrer"><span class=sf-dump-str title="55 characters">Symfony\Component\VarDumper\Tests\Caster\StubCasterTest</span></a>"
103+
<span class=sf-dump-index>0</span> => "<a href="%sStubCasterTest.php:0" rel="noopener noreferrer"><span class=sf-dump-str title="55 characters">Symfony\Component\VarDumper\Tests\Caster\StubCasterTest</span></a>"
104+
</samp>]
105+
</bar>
106+
EODUMP;
107+
108+
$this->assertStringMatchesFormat($expectedDump, $dump);
109+
}
110+
111+
public function testLinkStubWithNoFileLink()
112+
{
113+
$var = array(new LinkStub('example.com', 0, 'http://example.com'));
114+
115+
$cloner = new VarCloner();
116+
$dumper = new HtmlDumper();
117+
$dumper->setDumpHeader('<foo></foo>');
118+
$dumper->setDumpBoundaries('<bar>', '</bar>');
119+
$dumper->setDisplayOptions(array('fileLinkFormat' => '%f:%l'));
120+
$dump = $dumper->dump($cloner->cloneVar($var), true);
121+
122+
$expectedDump = <<<'EODUMP'
123+
<foo></foo><bar><span class=sf-dump-note>array:1</span> [<samp>
124+
<span class=sf-dump-index>0</span> => "<a href="http://example.com" target="_blank" rel="noopener noreferrer"><span class=sf-dump-str title="11 characters">example.com</span></a>"
104125
</samp>]
105126
</bar>
106127
EODUMP;
@@ -120,7 +141,7 @@ public function testClassStub()
120141

121142
$expectedDump = <<<'EODUMP'
122143
<foo></foo><bar><span class=sf-dump-note>array:1</span> [<samp>
123-
<span class=sf-dump-index>0</span> => "<a href="%sFooInterface.php:10" target="_blank" rel="noopener noreferrer"><span class=sf-dump-str title="5 characters">hello</span></a>"
144+
<span class=sf-dump-index>0</span> => "<a href="%sFooInterface.php:10" rel="noopener noreferrer"><span class=sf-dump-str title="5 characters">hello</span></a>"
124145
</samp>]
125146
</bar>
126147
EODUMP;
@@ -161,7 +182,7 @@ public function testClassStubWithNotExistingMethod()
161182

162183
$expectedDump = <<<'EODUMP'
163184
<foo></foo><bar><span class=sf-dump-note>array:1</span> [<samp>
164-
<span class=sf-dump-index>0</span> => "<a href="%sFooInterface.php:5" target="_blank" rel="noopener noreferrer"><span class=sf-dump-str title="5 characters">hello</span></a>"
185+
<span class=sf-dump-index>0</span> => "<a href="%sFooInterface.php:5" rel="noopener noreferrer"><span class=sf-dump-str title="5 characters">hello</span></a>"
165186
</samp>]
166187
</bar>
167188
EODUMP;

0 commit comments

Comments
 (0)
0