Rename skipOnWindows helper method

bobvandevijver · bobvandevijver · commit 1346cb6d5e2d · 2024-04-17T11:52:44.000+02:00
diff --git a/src/Symfony/Component/Mailer/Tests/Transport/SendmailTransportTest.php b/src/Symfony/Component/Mailer/Tests/Transport/SendmailTransportTest.php
@@ -55,7 +55,7 @@ public function testToString()
 
     public function testToIsUsedWhenRecipientsAreNotSet()
     {
-        $this->skipWhenWindows();
+        $this->skipOnWindows();
 
         $mail = new Email();
         $mail
@@ -75,7 +75,7 @@ public function testToIsUsedWhenRecipientsAreNotSet()
 
     public function testRecipientsAreUsedWhenSet()
     {
-        $this->skipWhenWindows();
+        $this->skipOnWindows();
 
         [$mail, $envelope] = $this->defaultMailAndEnvelope();
 
@@ -87,7 +87,7 @@ public function testRecipientsAreUsedWhenSet()
 
     public function testThrowsTransportExceptionOnFailure()
     {
-        $this->skipWhenWindows();
+        $this->skipOnWindows();
 
         [$mail, $envelope] = $this->defaultMailAndEnvelope();
 
@@ -104,7 +104,7 @@ public function testThrowsTransportExceptionOnFailure()
 
     public function testStreamIsClearedOnFailure()
     {
-        $this->skipWhenWindows();
+        $this->skipOnWindows();
 
         [$mail, $envelope] = $this->defaultMailAndEnvelope();
 
@@ -124,7 +124,7 @@ public function testStreamIsClearedOnFailure()
 
     public function testDoesNotThrowWhenInteractive()
     {
-        $this->skipWhenWindows();
+        $this->skipOnWindows();
 
         [$mail, $envelope] = $this->defaultMailAndEnvelope();
 
@@ -161,7 +161,7 @@ public function __toString(): string
         $this->assertStringEqualsFile($this->argsPath, __DIR__.'/Fixtures/fake-failing-sendmail.php -bs');
     }
 
-    private function skipWhenWindows()
+    private function skipOnWindows()
     {
         if ('\\' === \DIRECTORY_SEPARATOR) {
             $this->markTestSkipped('Windows does not support shebangs nor non-blocking standard streams');

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ public function testToString()`
`55`	`55`
`56`	`56`	`public function testToIsUsedWhenRecipientsAreNotSet()`
`57`	`57`	`{`
`58`		`- $this->skipWhenWindows();`
	`58`	`+ $this->skipOnWindows();`
`59`	`59`
`60`	`60`	`$mail = new Email();`
`61`	`61`	`$mail`
`@@ -75,7 +75,7 @@ public function testToIsUsedWhenRecipientsAreNotSet()`
`75`	`75`
`76`	`76`	`public function testRecipientsAreUsedWhenSet()`
`77`	`77`	`{`
`78`		`- $this->skipWhenWindows();`
	`78`	`+ $this->skipOnWindows();`
`79`	`79`
`80`	`80`	`[$mail, $envelope] = $this->defaultMailAndEnvelope();`
`81`	`81`
`@@ -87,7 +87,7 @@ public function testRecipientsAreUsedWhenSet()`
`87`	`87`
`88`	`88`	`public function testThrowsTransportExceptionOnFailure()`
`89`	`89`	`{`
`90`		`- $this->skipWhenWindows();`
	`90`	`+ $this->skipOnWindows();`
`91`	`91`
`92`	`92`	`[$mail, $envelope] = $this->defaultMailAndEnvelope();`
`93`	`93`
`@@ -104,7 +104,7 @@ public function testThrowsTransportExceptionOnFailure()`
`104`	`104`
`105`	`105`	`public function testStreamIsClearedOnFailure()`
`106`	`106`	`{`
`107`		`- $this->skipWhenWindows();`
	`107`	`+ $this->skipOnWindows();`
`108`	`108`
`109`	`109`	`[$mail, $envelope] = $this->defaultMailAndEnvelope();`
`110`	`110`
`@@ -124,7 +124,7 @@ public function testStreamIsClearedOnFailure()`
`124`	`124`
`125`	`125`	`public function testDoesNotThrowWhenInteractive()`
`126`	`126`	`{`
`127`		`- $this->skipWhenWindows();`
	`127`	`+ $this->skipOnWindows();`
`128`	`128`
`129`	`129`	`[$mail, $envelope] = $this->defaultMailAndEnvelope();`
`130`	`130`
`@@ -161,7 +161,7 @@ public function __toString(): string`
`161`	`161`	`$this->assertStringEqualsFile($this->argsPath, __DIR__.'/Fixtures/fake-failing-sendmail.php -bs');`
`162`	`162`	`}`
`163`	`163`
`164`		`- private function skipWhenWindows()`
	`164`	`+ private function skipOnWindows()`
`165`	`165`	`{`
`166`	`166`	`if ('\\' === \DIRECTORY_SEPARATOR) {`
`167`	`167`	`$this->markTestSkipped('Windows does not support shebangs nor non-blocking standard streams');`