[Console] Handle SIGQUIT signal

ostrolucky · ostrolucky · commit 12c1bf030883 · 2024-04-06T19:21:51.000+02:00
As both PHP-FPM and NGINX use SIGQUIT for graceful shutdown, I believe it's necessary PHP applications should also support it. It's especially important in cases where you run PHP application in container running php/nginx image, since they override shutdown signal that docker uses to SIGQUIT, see nginx/docker-nginx@3fb70dd
diff --git a/src/Symfony/Component/Console/Application.php b/src/Symfony/Component/Console/Application.php
@@ -97,7 +97,7 @@ public function __construct(
         $this->defaultCommand = 'list';
         if (\defined('SIGINT') && SignalRegistry::isSupported()) {
             $this->signalRegistry = new SignalRegistry();
-            $this->signalsToDispatchEvent = [\SIGINT, \SIGTERM, \SIGUSR1, \SIGUSR2];
+            $this->signalsToDispatchEvent = [\SIGINT, \SIGQUIT, \SIGTERM, \SIGUSR1, \SIGUSR2];
         }
     }
 
@@ -984,7 +984,7 @@ protected function doRunCommand(Command $command, InputInterface $input, OutputI
             if (Terminal::hasSttyAvailable()) {
                 $sttyMode = shell_exec('stty -g');
 
-                foreach ([\SIGINT, \SIGTERM] as $signal) {
+                foreach ([\SIGINT, \SIGQUIT, \SIGTERM] as $signal) {
                     $this->signalRegistry->register($signal, static fn () => shell_exec('stty '.$sttyMode));
                 }
             }
diff --git a/src/Symfony/Component/Messenger/Command/ConsumeMessagesCommand.php b/src/Symfony/Component/Messenger/Command/ConsumeMessagesCommand.php
@@ -264,7 +264,7 @@ public function complete(CompletionInput $input, CompletionSuggestions $suggesti
 
     public function getSubscribedSignals(): array
     {
-        return $this->signals ?? (\extension_loaded('pcntl') ? [\SIGTERM, \SIGINT] : []);
+        return $this->signals ?? (\extension_loaded('pcntl') ? [\SIGTERM, \SIGINT, \SIGQUIT] : []);
     }
 
     public function handleSignal(int $signal, int|false $previousExitCode = 0): int|false
diff --git a/src/Symfony/Component/Messenger/Command/FailedMessagesRetryCommand.php b/src/Symfony/Component/Messenger/Command/FailedMessagesRetryCommand.php
@@ -132,7 +132,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 
     public function getSubscribedSignals(): array
     {
-        return $this->signals ?? (\extension_loaded('pcntl') ? [\SIGTERM, \SIGINT] : []);
+        return $this->signals ?? (\extension_loaded('pcntl') ? [\SIGTERM, \SIGINT, \SIGQUIT] : []);
     }
 
     public function handleSignal(int $signal, int|false $previousExitCode = 0): int|false

Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,7 @@ public function __construct(`
`97`	`97`	`$this->defaultCommand = 'list';`
`98`	`98`	`if (\defined('SIGINT') && SignalRegistry::isSupported()) {`
`99`	`99`	`$this->signalRegistry = new SignalRegistry();`
`100`		`- $this->signalsToDispatchEvent = [\SIGINT, \SIGTERM, \SIGUSR1, \SIGUSR2];`
	`100`	`+ $this->signalsToDispatchEvent = [\SIGINT, \SIGQUIT, \SIGTERM, \SIGUSR1, \SIGUSR2];`
`101`	`101`	`}`
`102`	`102`	`}`
`103`	`103`
`@@ -984,7 +984,7 @@ protected function doRunCommand(Command $command, InputInterface $input, OutputI`
`984`	`984`	`if (Terminal::hasSttyAvailable()) {`
`985`	`985`	`$sttyMode = shell_exec('stty -g');`
`986`	`986`
`987`		`- foreach ([\SIGINT, \SIGTERM] as $signal) {`
	`987`	`+ foreach ([\SIGINT, \SIGQUIT, \SIGTERM] as $signal) {`
`988`	`988`	`$this->signalRegistry->register($signal, static fn () => shell_exec('stty '.$sttyMode));`
`989`	`989`	`}`
`990`	`990`	`}`
Original file line number	Diff line number	Diff line change
`@@ -264,7 +264,7 @@ public function complete(CompletionInput $input, CompletionSuggestions $suggesti`
`264`	`264`
`265`	`265`	`public function getSubscribedSignals(): array`
`266`	`266`	`{`
`267`		`- return $this->signals ?? (\extension_loaded('pcntl') ? [\SIGTERM, \SIGINT] : []);`
	`267`	`+ return $this->signals ?? (\extension_loaded('pcntl') ? [\SIGTERM, \SIGINT, \SIGQUIT] : []);`
`268`	`268`	`}`
`269`	`269`
`270`	`270`	`public function handleSignal(int $signal, int\|false $previousExitCode = 0): int\|false`
Original file line number	Diff line number	Diff line change
`@@ -132,7 +132,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int`
`132`	`132`
`133`	`133`	`public function getSubscribedSignals(): array`
`134`	`134`	`{`
`135`		`- return $this->signals ?? (\extension_loaded('pcntl') ? [\SIGTERM, \SIGINT] : []);`
	`135`	`+ return $this->signals ?? (\extension_loaded('pcntl') ? [\SIGTERM, \SIGINT, \SIGQUIT] : []);`
`136`	`136`	`}`
`137`	`137`
`138`	`138`	`public function handleSignal(int $signal, int\|false $previousExitCode = 0): int\|false`