minor #54790 [TypeInfo] end/current instead of array_pop (soyuka)

fabpot · fabpot · commit 1119ab6b4937 · 2024-05-01T15:49:46.000+02:00
This PR was merged into the 7.1 branch. Discussion ---------- [TypeInfo] end/current instead of array_pop | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | no | New feature? | no | Deprecations? | no | License | MIT We don't need to modify the array here, I think it's a micro-optimization to use `end` and `current` instead of changing an array size. Commits ------- e36b82d [TypeInfo] end/current instead of array_pop
diff --git a/src/Symfony/Component/TypeInfo/TypeContext/TypeContextFactory.php b/src/Symfony/Component/TypeInfo/TypeContext/TypeContextFactory.php
@@ -50,11 +50,11 @@ public function createFromClassName(string $calledClassName, ?string $declaringC
         $calledClassPath = explode('\\', $calledClassName);
         $declaringClassPath = explode('\\', $declaringClassName);
 
-        $declaringClassReflection = (self::$reflectionClassCache[$declaringClassName] ??= new \ReflectionClass($declaringClassName));
+        $declaringClassReflection = self::$reflectionClassCache[$declaringClassName] ??= new \ReflectionClass($declaringClassName);
 
         $typeContext = new TypeContext(
-            array_pop($calledClassPath),
-            array_pop($declaringClassPath),
+            end($calledClassPath),
+            end($declaringClassPath),
             trim($declaringClassReflection->getNamespaceName(), '\\'),
             $this->collectUses($declaringClassReflection),
         );
