bug #26875 [Console] Don't go past exact matches when autocompleting (nicolas-grekas)

chalasr · chalasr · commit 10674688dada · 2018-04-10T11:58:27.000+02:00
This PR was merged into the 2.7 branch. Discussion ---------- [Console] Don't go past exact matches when autocompleting | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #21789 | License | MIT | Doc PR | - Commits ------- adba79a [Console] Don't go past exact matches when autocompleting
diff --git a/src/Symfony/Component/Console/Helper/QuestionHelper.php b/src/Symfony/Component/Console/Helper/QuestionHelper.php
@@ -284,7 +284,7 @@ private function autocomplete(OutputInterface $output, Question $question, $inpu
 
                 foreach ($autocomplete as $value) {
                     // If typed characters match the beginning chunk of value (e.g. [AcmeDe]moBundle)
-                    if (0 === strpos($value, $ret) && $i !== strlen($value)) {
+                    if (0 === strpos($value, $ret)) {
                         $matches[$numMatches++] = $value;
                     }
                 }
diff --git a/src/Symfony/Component/Console/Tests/Helper/QuestionHelperTest.php b/src/Symfony/Component/Console/Tests/Helper/QuestionHelperTest.php
@@ -160,6 +160,30 @@ public function testAskWithAutocompleteWithNonSequentialKeys()
         $this->assertEquals('AsseticBundle', $dialog->ask($this->createInputInterfaceMock(), $this->createOutputInterface(), $question));
     }
 
+    public function testAskWithAutocompleteWithExactMatch()
+    {
+        if (!$this->hasSttyAvailable()) {
+            $this->markTestSkipped('`stty` is required to test autocomplete functionality');
+        }
+
+        $inputStream = $this->getInputStream("b\n");
+
+        $possibleChoices = array(
+            'a' => 'berlin',
+            'b' => 'copenhagen',
+            'c' => 'amsterdam',
+        );
+
+        $dialog = new QuestionHelper();
+        $dialog->setInputStream($inputStream);
+        $dialog->setHelperSet(new HelperSet(array(new FormatterHelper())));
+
+        $question = new ChoiceQuestion('Please select a city', $possibleChoices);
+        $question->setMaxAttempts(1);
+
+        $this->assertSame('b', $dialog->ask($this->createInputInterfaceMock(), $this->createOutputInterface(), $question));
+    }
+
     public function testAutocompleteWithTrailingBackslash()
     {
         if (!$this->hasSttyAvailable()) {

Original file line number	Diff line number	Diff line change
`@@ -284,7 +284,7 @@ private function autocomplete(OutputInterface $output, Question $question, $inpu`
`284`	`284`
`285`	`285`	`foreach ($autocomplete as $value) {`
`286`	`286`	`// If typed characters match the beginning chunk of value (e.g. [AcmeDe]moBundle)`
`287`		`- if (0 === strpos($value, $ret) && $i !== strlen($value)) {`
	`287`	`+ if (0 === strpos($value, $ret)) {`
`288`	`288`	`$matches[$numMatches++] = $value;`
`289`	`289`	`}`
`290`	`290`	`}`