bug #35616 [Workflow] Make method signature compatible with 4.4 (pbowyer)

lyrixx · lyrixx · commit 0febb62ad819 · 2020-02-06T14:45:10.000+01:00
This PR was squashed before being merged into the 5.0 branch (closes #35616). Discussion ---------- [Workflow] Make method signature compatible with 4.4 | Q | A | ------------- | --- | Branch? | 5.0  | Bug fix? | yes | New feature? | no  | Deprecations? | no  | Tickets | Fix #35615  | License | MIT | Doc PR | symfony/symfony-docs#...   A method signature changed in a non-backwards-compatible way in 5.0.0 - and in only one class. This commit fixes that - and has been tested. For full details see ticket #35615. Commits ------- 474be96 [Workflow] Make method signature compatible with 4.4
diff --git a/src/Symfony/Component/Workflow/Event/Event.php b/src/Symfony/Component/Workflow/Event/Event.php
@@ -60,7 +60,7 @@ public function getWorkflowName()
         return $this->workflow->getName();
     }
 
-    public function getMetadata(string $key, object $subject)
+    public function getMetadata(string $key, $subject)
     {
         return $this->workflow->getMetadataStore()->getMetadata($key, $subject);
     }

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ public function getWorkflowName()`
`60`	`60`	`return $this->workflow->getName();`
`61`	`61`	`}`
`62`	`62`
`63`		`- public function getMetadata(string $key, object $subject)`
	`63`	`+ public function getMetadata(string $key, $subject)`
`64`	`64`	`{`
`65`	`65`	`return $this->workflow->getMetadataStore()->getMetadata($key, $subject);`
`66`	`66`	`}`