[RateLimiter] Adding default empty value

David-Crty · web-flow · commit 0fdfcae49991 · 2022-04-05T15:17:42.000+02:00
Because Security::LAST_USERNAME not always exist, it can trigger a "preg_match(): Argument #2 ($subject) must be of type string" if $username is null
diff --git a/src/Symfony/Component/Security/Http/RateLimiter/DefaultLoginRateLimiter.php b/src/Symfony/Component/Security/Http/RateLimiter/DefaultLoginRateLimiter.php
@@ -37,7 +37,7 @@ public function __construct(RateLimiterFactory $globalFactory, RateLimiterFactor
 
     protected function getLimiters(Request $request): array
     {
-        $username = $request->attributes->get(Security::LAST_USERNAME);
+        $username = $request->attributes->get(Security::LAST_USERNAME, '');
         $username = preg_match('//u', $username) ? mb_strtolower($username, 'UTF-8') : strtolower($username);
 
         return [

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ public function __construct(RateLimiterFactory $globalFactory, RateLimiterFactor`
`37`	`37`
`38`	`38`	`protected function getLimiters(Request $request): array`
`39`	`39`	`{`
`40`		`- $username = $request->attributes->get(Security::LAST_USERNAME);`
	`40`	`+ $username = $request->attributes->get(Security::LAST_USERNAME, '');`
`41`	`41`	`$username = preg_match('//u', $username) ? mb_strtolower($username, 'UTF-8') : strtolower($username);`
`42`	`42`
`43`	`43`	`return [`