bug #36069 [DI] skip untyped properties in AutowireRequiredPropertiesPass (nicolas-grekas)

fabpot · fabpot · commit 0fb0371029b2 · 2020-03-16T07:13:08.000+01:00
This PR was merged into the 5.1-dev branch. Discussion ---------- [DI] skip untyped properties in AutowireRequiredPropertiesPass | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Commits ------- 048d092 [DI] skip untyped properties in AutowireRequiredPropertiesPass
diff --git a/src/Symfony/Component/DependencyInjection/Compiler/AutowireRequiredPropertiesPass.php b/src/Symfony/Component/DependencyInjection/Compiler/AutowireRequiredPropertiesPass.php
@@ -42,6 +42,9 @@ protected function processValue($value, bool $isRoot = false)
 
         $properties = $value->getProperties();
         foreach ($reflectionClass->getProperties() as $reflectionProperty) {
+            if (!$reflectionProperty->hasType()) {
+                continue;
+            }
             if (false === $doc = $reflectionProperty->getDocComment()) {
                 continue;
             }
diff --git a/src/Symfony/Component/DependencyInjection/Tests/Fixtures/includes/autowiring_classes_74.php b/src/Symfony/Component/DependencyInjection/Tests/Fixtures/includes/autowiring_classes_74.php
@@ -9,6 +9,11 @@ class PropertiesInjection
      */
     public Bar $plop;
 
+    /**
+     * @required
+     */
+    public $plip;
+
     public function __construct(A $a)
     {
     }

Original file line number	Diff line number	Diff line change
`@@ -42,6 +42,9 @@ protected function processValue($value, bool $isRoot = false)`
`42`	`42`
`43`	`43`	`$properties = $value->getProperties();`
`44`	`44`	`foreach ($reflectionClass->getProperties() as $reflectionProperty) {`
	`45`	`+ if (!$reflectionProperty->hasType()) {`
	`46`	`+ continue;`
	`47`	`+ }`
`45`	`48`	`if (false === $doc = $reflectionProperty->getDocComment()) {`
`46`	`49`	`continue;`
`47`	`50`	`}`
Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,11 @@ class PropertiesInjection`
`9`	`9`	`*/`
`10`	`10`	`public Bar $plop;`
`11`	`11`
	`12`	`+ /**`
	`13`	`+ * @required`
	`14`	`+ */`
	`15`	`+ public $plip;`
	`16`	`+`
`12`	`17`	`public function __construct(A $a)`
`13`	`18`	`{`
`14`	`19`	`}`