8000 minor #38636 Enable Doctrine tests on php 8 (derrabus) · symfony/symfony@0e468e5 · GitHub
[go: up one dir, main page]
Skip to content

Commit 0e468e5

Browse files
fabpotfabpot
committed
minor #38636 Enable Doctrine tests on php 8 (derrabus)
This PR was merged into the 3.4 branch. Discussion ---------- Enable Doctrine tests on php 8 | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | #36872 | License | MIT | Doc PR | N/A Following doctrine/dbal#4347, this PR enables all Doctrine tests on php 8. Commits ------- f4a99b2 Don't skip Doctrine tests on php 8.
2 parents 0721a0e + f4a99b2 commit 0e468e5

File tree

7 files changed

+0
-45
lines changed

7 files changed

+0
-45
lines changed

‎src/Symfony/Bridge/Doctrine/Tests/Form/Type/EntityTypeTest.php

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -61,13 +61,6 @@ class EntityTypeTest extends BaseTypeTest
6161

6262
protected static $supportedFeatureSetVersion = 304;
6363

64-
public static function setUpBeforeClass()
65-
{
66-
if (\PHP_VERSION_ID >= 80000) {
67-
self::markTestSkipped('Doctrine DBAL 2.x is incompatible with PHP 8.');
68-
}
69-
}
70-
7164
protected function setUp()
7265
{
7366
$this->em = DoctrineTestHelper::createTestEntityManager();

‎src/Symfony/Bridge/Doctrine/Tests/Security/RememberMe/DoctrineTokenProviderTest.php

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,6 @@
1313
*/
1414
class DoctrineTokenProviderTest extends TestCase
1515
{
16-
public static function setUpBeforeClass()
17-
{
18-
if (\PHP_VERSION_ID >= 80000) {
19-
self::markTestSkipped('Doctrine DBAL 2.x is incompatible with PHP 8.');
20-
}
21-
}
22-
2316
public function testCreateNewToken()
2417
{
2518
$provider = $this->bootstrapProvider();

‎src/Symfony/Bridge/Doctrine/Tests/Security/User/EntityUserProviderTest.php

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -23,13 +23,6 @@
< 8000 /td>
2323

2424
class EntityUserProviderTest extends TestCase
2525
{
26-
public static function setUpBeforeClass()
27-
{
28-
if (\PHP_VERSION_ID >= 80000) {
29-
self::markTestSkipped('Doctrine DBAL 2.x is incompatible with PHP 8.');
30-
}
31-
}
32-
3326
public function testRefreshUserGetsUserByPrimaryKey()
3427
{
3528
$em = DoctrineTestHelper::createTestEntityManager();

‎src/Symfony/Bridge/Doctrine/Tests/Validator/Constraints/UniqueEntityValidatorTest.php

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -63,13 +63,6 @@ class UniqueEntityValidatorTest extends ConstraintValidatorTestCase
6363

6464
protected $repositoryFactory;
6565

66-
public static function setUpBeforeClass()
67-
{
68-
if (\PHP_VERSION_ID >= 80000) {
69-
self::markTestSkipped('Doctrine DBAL 2.x is incompatible with PHP 8.');
70-
}
71-
}
72-
7366
protected function setUp()
7467
{
7568
$this->repositoryFactory = new TestRepositoryFactory();

‎src/Symfony/Bundle/SecurityBundle/Tests/Functional/SetAclCommandTest.php

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -40,13 +40,6 @@ class SetAclCommandTest extends AbstractWebTestCase
4040
const OBJECT_CLASS = 'Symfony\Bundle\SecurityBundle\Tests\Functional\Bundle\AclBundle\Entity\Car';
4141
const SECURITY_CLASS = 'Symfony\Component\Security\Core\User\User';
4242

43-
public static function setUpBeforeClass()
44-
{
45-
if (\PHP_VERSION_ID >= 80000) {
46-
self::markTestSkipped('Doctrine DBAL 2.x is incompatible with PHP 8.');
47-
}
48-
}
49-
5043
public function testSetAclUser()
5144
{
5245
$objectId = 1;

‎src/Symfony/Component/Cache/Tests/Adapter/PdoDbalAdapterTest.php

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
namespace Symfony\Component\Cache\Tests\Adapter;
1313

1414
use Doctrine\DBAL\DriverManager;
15-
use Doctrine\DBAL\Version;
1615
use Symfony\Component\Cache\Adapter\PdoAdapter;
1716
use Symfony\Component\Cache\Tests\Traits\PdoPruneableTrait;
1817

@@ -31,10 +30,6 @@ public static function setUpBeforeClass()
3130
self::markTestSkipped('Extension pdo_sqlite required.');
3231
}
3332

34-
if (\PHP_VERSION_ID >= 80000 && class_exists(Version::class)) {
35-
self::markTestSkipped('Doctrine DBAL 2.x is incompatible with PHP 8.');
36-
}
37-
3833
self::$dbFile = tempnam(sys_get_temp_dir(), 'sf_sqlite_cache');
3934

4035
$pool = new PdoAdapter(DriverManager::getConnection(['driver' => 'pdo_sqlite', 'path' => self::$dbFile]));

‎src/Symfony/Component/Cache/Tests/Simple/PdoDbalCacheTest.php

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
namespace Symfony\Component\Cache\Tests\Simple;
1313

1414
use Doctrine\DBAL\DriverManager;
15-
use Doctrine\DBAL\Version;
1615
use Symfony\Component\Cache\Simple\PdoCache;
1716
use Symfony\Component\Cache\Tests\Traits\PdoPruneableTrait;
1817

@@ -31,10 +30,6 @@ public static function setUpBeforeClass()
3130
self::markTestSkipped('Extension pdo_sqlite required.');
3231
}
3332

34-
if (\PHP_VERSION_ID >= 80000 && class_exists(Version::class)) {
35-
self::markTestSkipped('Doctrine DBAL 2.x is incompatible with PHP 8.');
36-
}
37-
3833
self::$dbFile = tempnam(sys_get_temp_dir(), 'sf_sqlite_cache');
3934

4035
$pool = new PdoCache(DriverManager::getConnection(['driver' => 'pdo_sqlite', 'path' => self::$dbFile]));

0 commit comments

Comments
 (0)
0