8000 bug #20607 [Validator] Bring egulias/email-validator ~2.0 to parity w… · symfony/symfony@0e12427 · GitHub
[go: up one dir, main page]
Skip to content

Commit 0e12427

Browse files
nicolas-grekasnicolas-grekas
committed
bug #20607 [Validator] Bring egulias/email-validator ~2.0 to parity with ~1.2 (Lctrs)
This PR was merged into the 3.2 branch. Discussion ---------- [Validator] Bring egulias/email-validator ~2.0 to parity with ~1.2 | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | could be ? | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | When using egulias/email-validator ~1.2, we make a strict check of the email, which means that emails with RFC warnings will fail validation. Currently with egulias/email-validator ~2.0, emails with warnings are considerate valids. This pull request make EmailValidator with egulias/email-validator ~2.0 behave as with egulias/email-validator ~1.2. Commits ------- 01b2f66 Switch to NoRFCWarningsValidation
2 parents bd5af67 + 01b2f66 commit 0e12427

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

‎src/Symfony/Component/Validator/Constraints/EmailValidator.php‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
namespace Symfony\Component\Validator\Constraints;
1313

1414
use Egulias\EmailValidator\Validation\EmailValidation;
15-
use Egulias\EmailValidator\Validation\RFCValidation;
15+
use Egulias\EmailValidator\Validation\NoRFCWarningsValidation;
1616
use Symfony\Component\Validator\Constraint;
1717
use Symfony\Component\Validator\ConstraintValidator;
1818
use Symfony\Component\Validator\Exception\RuntimeException;
@@ -63,7 +63,7 @@ public function validate($value, Constraint $constraint)
6363

6464
$strictValidator = new \Egulias\EmailValidator\EmailValidator();
6565

66-
if (interface_exists(EmailValidation::class) && !$strictValidator->isValid($value, new RFCValidation())) {
66+
if (interface_exists(EmailValidation::class) && !$strictValidator->isValid($value, new NoRFCWarningsValidation())) {
6767
$this->context->buildViolation($constraint->message)
6868
->setParameter('{{ value }}', $this->formatValue($value))
6969
->setCode(Email::INVALID_FORMAT_ERROR)

‎src/Symfony/Component/Validator/Tests/Constraints/EmailValidatorTest.php‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -174,6 +174,7 @@ public function getInvalidEmailsForStrictChecks()
174174
array('test@email>'),
175175
array('test@email<'),
176176
array('test@email{'),
177+
array(str_repeat('x', 254).'@example.com'), //email with warnings
177178
);
178179
}
179180

0 commit comments

Comments
 (0)
0