[HttpFoundation] Compare cookie with null value as empty string in ResponseCookieValueSame

fancyweb · fancyweb · commit 0cc736829a1d · 2022-11-04T17:17:57.000+01:00
diff --git a/src/Symfony/Component/HttpFoundation/Test/Constraint/ResponseCookieValueSame.php b/src/Symfony/Component/HttpFoundation/Test/Constraint/ResponseCookieValueSame.php
@@ -59,7 +59,7 @@ protected function matches($response): bool
             return false;
         }
 
-        return $this->value === $cookie->getValue();
+        return $this->value === (string) $cookie->getValue();
     }
 
     /**
diff --git a/src/Symfony/Component/HttpFoundation/Tests/Test/Constraint/ResponseCookieValueSameTest.php b/src/Symfony/Component/HttpFoundation/Tests/Test/Constraint/ResponseCookieValueSameTest.php
@@ -41,4 +41,12 @@ public function testConstraint()
 
         $this->fail();
     }
+
+    public function testCookieWithNullValueIsComparedAsEmptyString()
+    {
+        $response = new Response();
+        $response->headers->setCookie(Cookie::create('foo', null, 0, '/path'));
+
+        $this->assertTrue((new ResponseCookieValueSame('foo', '', '/path'))->evaluate($response, '', true));
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ protected function matches($response): bool`
`59`	`59`	`return false;`
`60`	`60`	`}`
`61`	`61`
`62`		`- return $this->value === $cookie->getValue();`
	`62`	`+ return $this->value === (string) $cookie->getValue();`
`63`	`63`	`}`
`64`	`64`
`65`	`65`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -41,4 +41,12 @@ public function testConstraint()`
`41`	`41`
`42`	`42`	`$this->fail();`
`43`	`43`	`}`
	`44`	`+`
	`45`	`+ public function testCookieWithNullValueIsComparedAsEmptyString()`
	`46`	`+ {`
	`47`	`+ $response = new Response();`
	`48`	`+ $response->headers->setCookie(Cookie::create('foo', null, 0, '/path'));`
	`49`	`+`
	`50`	`+ $this->assertTrue((new ResponseCookieValueSame('foo', '', '/path'))->evaluate($response, '', true));`
	`51`	`+ }`
`44`	`52`	`}`