8000 [Messenger] Deprecate `StopWorkerOnSignalsListener` · symfony/symfony@0b62ce8 · GitHub
[go: up one dir, main page]
Skip to content

Commit 0b62ce8

Browse files
HypeMCHypeMC
committed
[Messenger] Deprecate StopWorkerOnSignalsListener 
1 parent 68f27ef commit 0b62ce8

File tree

5 files changed

+19
-4
lines changed

5 files changed

+19
-4
lines changed

‎UPGRADE-6.4.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,11 @@ HttpKernel
4646
* `BundleInterface` no longer extends `ContainerAwareInterface`
4747
* Add native return types to `TraceableEventDispatcher` and to `MergeExtensionConfigurationPass`
4848

49+
Messenger
50+
---------
51+
52+
* Deprecate `StopWorkerOnSignalsListener` in favor of using the `SignalableCommandInterface`
53+
4954
MonologBridge
5055
-------------
5156

‎src/Symfony/Bundle/FrameworkBundle/Resources/config/messenger.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -202,6 +202,7 @@
202202
->tag('monolog.logger', ['channel' => 'messenger'])
203203

204204
->set('messenger.listener.stop_worker_signals_listener', StopWorkerOnSignalsListener::class)
205+
->deprecate('6.4', 'symfony/messenger', 'The "%service_id%" service is deprecated, use the "Symfony\Component\Console\Command\SignalableCommandInterface" instead.')
205206
->args([
206207
null,
207208
service('logger')->ignoreOnInvalid(),
@@ -210,7 +211,7 @@
210211
->tag('monolog.logger', ['channel' => 'messenger'])
211212

212213
->alias('messenger.listener.stop_worker_on_sigterm_signal_listener', 'messenger.listener.stop_worker_signals_listener')
213-
->deprecate('6.3', 'symfony/messenger', 'The "%alias_id%" service is deprecated, use "messenger.listener.stop_worker_signals_listener" instead.')
214+
->deprecate('6.3', 'symfony/messenger', 'The "%alias_id%" service is deprecated, use the "Symfony\Component\Console\Command\SignalableCommandInterface" instead.')
214215

215216
->set('messenger.listener.stop_worker_on_stop_exception_listener', StopWorkerOnCustomStopExceptionListener::class)
216217
->tag('kernel.event_subscriber')

‎src/Symfony/Component/Messenger/CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
CHANGELOG
22
=========
33

4+
6.4
5+
---
6+
7+
* Deprecate `StopWorkerOnSignalsListener` in favor of using the `SignalableCommandInterface`
8+
49
6.3
510
---
611

‎src/Symfony/Component/Messenger/EventListener/StopWorkerOnSignalsListener.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,15 @@
1212
namespace Symfony\Component\Messenger\EventListener;
1313

1414
use Psr\Log\LoggerInterface;
15+
use Symfony\Component\Console\Command\SignalableCommandInterface;
1516
use Symfony\Component\EventDispatcher\EventSubscriberInterface;
1617
use Symfony\Component\Messenger\Event\WorkerStartedEvent;
1718

1819
/**
1920
* @author Tobias Schultze <http://tobion.de>
2021
* @author Grégoire Pineau <lyrixx@lyrixx.info>
22+
*
23+
* @deprecated since Symfony 6.4, use the {@see SignalableCommandInterface} instead
2124
*/
2225
class StopWorkerOnSignalsListener implements EventSubscriberInterface
2326
{

‎src/Symfony/Component/Messenger/EventListener/StopWorkerOnSigtermSignalListener.php

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,14 +11,15 @@
1111

1212
namespace Symfony\Component\Messenger\EventListener;
1313

14-
trigger_deprecation('symfony/messenger', '6.3', '"%s" is deprecated, use "%s" instead.', StopWorkerOnSigtermSignalListener::class, StopWorkerOnSignalsListener::class);
15-
1614
use Psr\Log\LoggerInterface;
15+
use Symfony\Component\Console\Command\SignalableCommandInterface;
16+
17+
trigger_deprecation('symfony/messenger', '6.3', '"%s" is deprecated, use the "%s" instead.', StopWorkerOnSigtermSignalListener::class, SignalableCommandInterface::class);
1718

1819
/**
1920
* @author Tobias Schultze <http://tobion.de>
2021
*
21-
* @deprecated since Symfony 6.3, use the StopWorkerOnSignalsListener instead
22+
* @deprecated since Symfony 6.3, use the {@see SignalableCommandInterface} instead
2223
*/
2324
class StopWorkerOnSigtermSignalListener extends StopWorkerOnSignalsListener
2425
{

0 commit comments

Comments
 (0)
0