bug #47394 [Console] [Completion] Make bash completion run in non interactive mode (Seldaek)

fabpot · fabpot · commit 0b0cbd341c92 · 2022-09-02T12:14:53.000+02:00
This PR was merged into the 5.4 branch. Discussion ---------- [Console] [Completion] Make bash completion run in non interactive mode | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no  | Deprecations? | no  | Tickets | Fix #...  | License | MIT | Doc PR | symfony/symfony-docs#...  Refs composer/composer#11024 Composer does prompt in some contexts, and that blocks/freezes the completion as it runs in an interactive context but is not actually visible. Explicitly setting it to be non interactive seems to be the fix to me. TODO: - [ ] A similar fix probably should be applied to other completion types supported in newer versions than 5.4 Commits ------- cf0b56f Make bash completion run in non interactive mode
diff --git a/src/Symfony/Component/Console/Resources/completion.bash b/src/Symfony/Component/Console/Resources/completion.bash
@@ -24,7 +24,7 @@ _sf_{{ COMMAND_NAME }}() {
     local cur prev words cword
     _get_comp_words_by_ref -n := cur prev words cword
 
-    local completecmd=("$sf_cmd" "_complete" "-sbash" "-c$cword" "-S{{ VERSION }}")
+    local completecmd=("$sf_cmd" "_complete" "--no-interaction" "-sbash" "-c$cword" "-S{{ VERSION }}")
     for w in ${words[@]}; do
         w=$(printf -- '%b' "$w")
         # remove quotes from typed values
