merged branch jankramer/master (PR #3478)

fabpot · fabpot · commit 0aac3613e1ef · 2012-03-15T16:46:57.000+01:00
Commits ------- e6577de Added a 'post validation' event to the form component. Discussion ---------- [Form] Add post-validate event Bug fix: no Feature addition: yes Backwards compatibility break: no Symfony2 tests pass: n/a Fixes the following tickets: n/a Todo: n/a --------------------------------------------------------------------------- by fabpot at 2012-03-02T20:34:18Z ping @bschussek --------------------------------------------------------------------------- by vicb at 2012-03-04T09:19:53Z I think this is a good idea (It was something missing to properly handle PersistentFile i.e. you should not persist invalid files) --------------------------------------------------------------------------- by vicb at 2012-03-09T22:35:26Z @jankramer please remove the second commit from this PR (see http://symfony.com/doc/current/contributing/code/patches.html) in order to make this mergeable. --------------------------------------------------------------------------- by jankramer at 2012-03-10T09:26:04Z @vicb done, sorry about that commit: overlooked the fact that it was on the same branch...
diff --git a/src/Symfony/Component/Form/Form.php b/src/Symfony/Component/Form/Form.php
@@ -566,6 +566,9 @@ public function bind($clientData)
         foreach ($this->validators as $validator) {
             $validator->validate($this);
         }
+        
+        $event = new DataEvent($this, $clientData);
+        $this->dispatcher->dispatch(FormEvents::POST_VALIDATE, $event);
 
         return $this;
     }
diff --git a/src/Symfony/Component/Form/FormEvents.php b/src/Symfony/Component/Form/FormEvents.php
@@ -29,4 +29,6 @@ final class FormEvents
     const BIND_NORM_DATA = 'form.bind_norm_data';
 
     const SET_DATA = 'form.set_data';
+    
+    const POST_VALIDATE = 'form.post_validate';
 }

Original file line number	Diff line number	Diff line change
`@@ -566,6 +566,9 @@ public function bind($clientData)`
`566`	`566`	`foreach ($this->validators as $validator) {`
`567`	`567`	`$validator->validate($this);`
`568`	`568`	`}`
	`569`	`+`
	`570`	`+ $event = new DataEvent($this, $clientData);`
	`571`	`+ $this->dispatcher->dispatch(FormEvents::POST_VALIDATE, $event);`
`569`	`572`
`570`	`573`	`return $this;`
`571`	`574`	`}`
Original file line number	Diff line number	Diff line change
`@@ -29,4 +29,6 @@ final class FormEvents`
`29`	`29`	`const BIND_NORM_DATA = 'form.bind_norm_data';`
`30`	`30`
`31`	`31`	`const SET_DATA = 'form.set_data';`
	`32`	`+`
	`33`	`+ const POST_VALIDATE = 'form.post_validate';`
`32`	`34`	`}`