8000 feature #47890 [SecurityBundle] Deprecate the `enable_authenticator_m… · symfony/symfony@0a3e393 · GitHub
[go: up one dir, main page]
Skip to content

Commit 0a3e393

Browse files
fabpotfabpot
committed
feature #47890 [SecurityBundle] Deprecate the enable_authenticator_manager option (chalasr)
This PR was merged into the 6.2 branch. Discussion ---------- [SecurityBundle] Deprecate the `enable_authenticator_manager` option | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | no | Deprecations? | yes | Tickets | - | License | MIT | Doc PR | - Last step before we close the chapter in 7.0 🎉 Commits ------- 0a826d0 [SecurityBundle] Deprecate the `enable_authenticator_manager` option
2 parents c2ad569 + 0a826d0 commit 0a3e393

File tree

112 files changed

+27
-152
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

112 files changed

+27
-152
lines changed

‎UPGRADE-6.2.md

Lines changed: 5 additions & 0 deletions

‎src/Symfony/Bundle/FrameworkBundle/Tests/Functional/app/Security/config.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@ services:
88
- container.service_subscriber
99

1010
security:
11-
enable_authenticator_manager: true
12-
1311
providers:
1412
main:
1513
memory:

‎src/Symfony/Bundle/SecurityBundle/CHANGELOG.md

Lines changed: 1 addition & 0 deletions

‎src/Symfony/Bundle/SecurityBundle/DependencyInjection/MainConfiguration.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ public function getConfigTreeBuilder(): TreeBuilder
6565
->end()
6666
->booleanNode('hide_user_not_found')->defaultTrue()->end()
6767
->booleanNode('erase_credentials')->defaultTrue()->end()
68-
->booleanNode('enable_authenticator_manager')->defaultTrue()->end()
68+
->booleanNode('enable_authenticator_manager')->setDeprecated('symfony/security-bundle', '6.2', 'The "%node%" option at "%path%" is deprecated.')->defaultTrue()->end()
6969
->arrayNode('access_decision_manager')
7070
->addDefaultsIfNotSet()
7171
->children()

‎src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/Compiler/AddSessionDomainConstraintPassTest.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,6 @@ private function createContainer($sessionStorageOptions)
139139

140140
$config = [
141141
'security' => [
142-
'enable_authenticator_manager' => true,
143142
'providers' => ['some_provider' => ['id' => 'foo']],
144143
'firewalls' => ['some_firewall' => ['security' => false]],
145144
],

‎src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/Compiler/RegisterGlobalSecurityEventListenersPassTest.php

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ protected function setUp(): void
5656
public function testEventIsPropagated(string $configuredEvent, string $registeredEvent)
5757
{
5858
$this->container->loadFromExtension('security', [
59-
'enable_authenticator_manager' => true,
6059
'firewalls' => ['main' => ['pattern' => '/', 'http_basic' => true]],
6160
]);
6261

@@ -90,7 +89,6 @@ public function providePropagatedEvents(): array
9089
public function testRegisterCustomListener()
9190
{
9291
$this->container->loadFromExtension('security', [
93-
'enable_authenticator_manager' => true,
9492
'firewalls' => ['main' => ['pattern' => '/', 'http_basic' => true]],
9593
]);
9694

@@ -111,7 +109,6 @@ public function testRegisterCustomListener()
111109
public function testRegisterCustomSubscriber()
112110
{
113111
$this->container->loadFromExtension('security', [
114-
'enable_authenticator_manager' => true,
115112
'firewalls' => ['main' => ['pattern' => '/', 'http_basic' => true]],
116113
]);
117114

@@ -131,7 +128,6 @@ public function testRegisterCustomSubscriber()
131128
public function testMultipleFirewalls()
132129
{
133130
$this->container->loadFromExtension('security', [
134-
'enable_authenticator_manager' => true,
135131
'firewalls' => ['main' => ['pattern' => '/', 'http_basic' => true], 'api' => ['pattern' => '/api', 'http_basic' => true]],
136132
]);
137133

@@ -161,7 +157,6 @@ public function testMultipleFirewalls()
161157
public function testListenerAlreadySpecific()
162158
{
163159
$this->container->loadFromExtension('security', [
164-
'enable_authenticator_manager' => true,
165160
'firewalls' => ['main' => ['pattern' => '/', 'http_basic' => true]],
166161
]);
167162

‎src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/Fixtures/php/access_decision_manager_customized_config.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
<?php
22

33
$container->loadFromExtension('security', [
4-
'enable_authenticator_manager' => true,
54
'access_decision_manager' => [
65
'allow_if_all_abstain' => true,
76
'allow_if_equal_granted_denied' => false,

‎src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/Fixtures/php/access_decision_manager_default_strategy.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
<?php
22

33
$container->loadFromExtension('security', [
4-
'enable_authenticator_manager' => true,
54
'providers' => [
65
'default' => [
76
'memory' => [

‎src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/Fixtures/php/access_decision_manager_service.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
<?php
22

33
$container->loadFromExtension('security', [
4-
'enable_authenticator_manager' => true,
54
'access_decision_manager' => [
65
'service' => 'app.access_decision_manager',
76
],

‎src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/Fixtures/php/access_decision_manager_service_and_strategy.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
<?php
22

33
$container->loadFromExtension('security', [
4-
'enable_authenticator_manager' => true,
54
'access_decision_manager' => [
65
'service' => 'app.access_decision_manager',
76
'strategy' => 'affirmative',

‎src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/Fixtures/php/access_decision_manager_strategy_service.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
<?php
22

33
$container->loadFromExtension('security', [
4-
'enable_authenticator_manager' => true,
54
'access_decision_manager' => [
65
'strategy_service' => 'app.custom_access_decision_strategy',
76
],

‎src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/Fixtures/php/argon2i_hasher.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
$this->load('container1.php');
44

55
$container->loadFromExtension('security', [
6-
'enable_authenticator_manager' => true,
76
'password_hashers' => [
87
'JMS\FooBundle\Entity\User7' => [
98
'algorithm' => 'argon2i',

‎src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/Fixtures/php/authenticator_manager.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
use Symfony\Component\Security\Http\Authenticator\Passport\Badge\CsrfTokenBadge;
44

55
$container->loadFromExtension('security', [
6-
'enable_authenticator_manager' => true,
76
'firewalls' => [
87
'main' => [
98
'required_badges' => [CsrfTokenBadge::class, 'RememberMeBadge'],

‎src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/Fixtures/php/bcrypt_hasher.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff F438 line change
@@ -3,7 +3,6 @@
33
$this->load('container1.php');
44

55
$container->loadFromExtension('security', [
6-
'enable_authenticator_manager' => true,
76
'password_hashers' => [
87
'JMS\FooBundle\Entity\User7' => [
98
'algorithm' => 'bcrypt',

‎src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/Fixtures/php/container1.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
<?php
22

33
$container->loadFromExtension('security', [
4-
'enable_authenticator_manager' => true,
54
'password_hashers' => [
65
'JMS\FooBundle\Entity\User1' => 'plaintext',
76
'JMS\FooBundle\Entity\User2' => [

‎src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/Fixtures/php/firewall_provider.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
<?php
22

33
$container->loadFromExtension('security', [
4-
'enable_authenticator_manager' => true,
54
'providers' => [
65
'default' => [
76
'memory' => $memory = [

‎src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/Fixtures/php/firewall_undefined_provider.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
<?php
22

33
$container->loadFromExtension('security', [
4-
'enable_authenticator_manager' => true,
54
'providers' => [
65
'default' => [
76
'memory' => [

‎src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/Fixtures/php/listener_provider.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
<?php
22

33
$container->loadFromExtension('security', [
4-
'enable_authenticator_manager' => true,
54
'providers' => [
65
'default' => [
76
'memory' => [

‎src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/Fixtures/php/listener_undefined_provider.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
<?php
22

33
$container->loadFromExtension('security', [
4-
'enable_authenticator_manager' => true,
54
'providers' => [
65
'default' => [
76
'memory' => [

‎src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/Fixtures/php/logout_delete_cookies.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
<?php
22

33
$container->loadFromExtension('security', [
4-
'enable_authenticator_manager' => true,
54
'providers' => [
65
'default' => ['id' => 'foo'],
76
],

‎src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/Fixtures/php/merge.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
$this->load('merge_import.php');
44

55
$container->loadFromExtension('security', [
6-
'enable_authenticator_manager' => true,
76
'providers' => [
87
'default' => ['id' => 'foo'],
98
],

‎src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/Fixtures/php/merge_import.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
<?php
22

33
$container->loadFromExtension('security', [
4-
'enable_authenticator_manager' => true,
54
'firewalls' => [
65
'main' => [
76
'form_login' => [

‎src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/Fixtures/php/migrating_hasher.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
$this->load('container1.php');
44

55
$container->loadFromExtension('security', [
6-
'enable_authenticator_manager' => true,
76
'password_hashers' => [
87
'JMS\FooBundle\Entity\User7' => [
98
'algorithm' => 'argon2i',

‎src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/Fixtures/php/no_custom_user_checker.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
<?php
22

33
$container->loadFromExtension('security', [
4-
'enable_authenticator_manager' => true,
54
'providers' => [
65
'default' => [
76
'memory' => [

‎src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/Fixtures/php/remember_me_options.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
<?php
22

33
$container->loadFromExtension('security', [
4-
'enable_authenticator_manager' => true,
54
'providers' => [
65
'default' => ['id' => 'foo'],
76
],

‎src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/Fixtures/php/sodium_hasher.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
$this->load('container1.php');
44

55
$container->loadFromExtension('security', [
6-
'enable_authenticator_manager' => true,
76
'password_hashers' => [
87
'JMS\FooBundle\Entity\User7' => [
98
'algorithm' => 'sodium',

‎src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/Fixtures/xml/access_decision_manager_customized_config.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
http://symfony.com/schema/dic/security
88
https://symfony.com/schema/dic/security/security-1.0.xsd">
99

10-
<config enable-authenticator-manager="true">
10+
<config>
1111
<access-decision-manager allow-if-all-abstain="true" allow-if-equal-granted-denied="false" />
1212

1313
<provider name="default">

‎src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/Fixtures/xml/access_decision_manager_default_strategy.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
http://symfony.com/schema/dic/security
88
https://symfony.com/schema/dic/security/security-1.0.xsd">
99

10-
<config enable-authenticator-manager="true">
10+
<config>
1111
<provider name="default">
1212
<memory>
1313
<user identifier="foo" password="foo" roles="ROLE_USER" />

‎src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/Fixtures/xml/access_decision_manager_service.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
http://symfony.com/schema/dic/security
88
https://symfony.com/schema/dic/security/security-1.0.xsd">
99

10-
<config enable-authenticator-manager="true">
10+
<config>
1111
<access-decision-manager service="app.access_decision_manager" />
1212

1313
<provider name="default">

‎src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/Fixtures/xml/access_decision_manager_service_and_strategy.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
http://symfony.com/schema/dic/security
88
https://symfony.com/schema/dic/security/security-1.0.xsd">
99

10-
<config enable-authenticator-manager="true">
10+
<config>
1111
<access-decision-manager service="app.access_decision_manager" strategy="affirmative" />
1212

1313
<provider name="default">

‎src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/Fixtures/xml/access_decision_manager_strategy_service.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
http://symfony.com/schema/dic/security
88
https://symfony.com/schema/dic/security/security-1.0.xsd">
99

10-
<config enable-authenticator-manager="true">
10+
<config>
1111
<access-decision-manager strategy-service="app.custom_access_decision_strategy" />
1212

1313
<provider name="default">

‎src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/Fixtures/xml/argon2i_hasher.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
<import resource="container1.xml"/>
1313
</imports>
1414

15-
<sec:config enable-authenticator-manager="true">
15+
<sec:config>
1616
<sec:password_hasher class="JMS\FooBundle\Entity\User7" algorithm="argon2i" memory-cost="256" time-cost="1" />
1717
</sec:config>
1818

‎src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/Fixtures/xml/authenticator_manager.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
http://symfony.com/schema/dic/security
88
https://symfony.com/schema/dic/security/security-1.0.xsd">
99

10-
<config enable-authenticator-manager="true">
10+
<config>
1111
<firewall name="main">
1212
<required-badge>Symfony\Component\Security\Http\Authenticator\Passport\Badge\CsrfTokenBadge</required-badge>
1313
<required-badge>RememberMeBadge</required-badge>

‎src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/Fixtures/xml/bcrypt_hasher.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
<import resource="container1.xml"/>
1313
</imports>
1414

15-
<sec:config enable-authenticator-manager="true">
15+
<sec:config>
1616
<sec:password_hasher class="JMS\FooBundle\Entity\User7" algorithm="bcrypt" cost="15" />
1717
</sec:config>
1818

‎src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/Fixtures/xml/container1.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
http://symfony.com/schema/dic/security
99
https://symfony.com/schema/dic/security/security-1.0.xsd">
1010

11-
<config enable-authenticator-manager="true">
11+
<config>
1212
<password_hasher class="JMS\FooBundle\Entity\User1" algorithm="plaintext" />
1313

1414
<password_hasher class="JMS\FooBundle\Entity\User2" algorithm="sha1" encode-as-base64="false" iterations="5" />

‎src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/Fixtures/xml/firewall_provider.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
http://symfony.com/schema/dic/security
99
https://symfony.com/schema/dic/security/security-1.0.xsd">
1010

11-
<sec:config enable-authenticator-manager="true">
11+
<sec:config>
1212
<sec:providers>
1313
<sec:provider name="with-dash" id="foo" />
1414
</sec:providers>

‎src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/Fixtures/xml/firewall_undefined_provider.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
http://symfony.com/schema/dic/security
99
https://symfony.com/schema/dic/security/security-1.0.xsd">
1010

11-
<sec:config enable-authenticator-manager="true">
11+
<sec:config>
1212
<sec:providers>
1313
<sec:provider name="default" id="foo" />
1414
</sec:providers>

‎src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/Fixtures/xml/listener_provider.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
http://symfony.com/schema/dic/security
99
https://symfony.com/schema/dic/security/security-1.0.xsd">
1010

11-
<sec:config enable-authenticator-manager="true">
11+
<sec:config>
1212
<sec:providers>
1313
<sec:provider name="default" id="foo" />
1414
</sec:providers>

‎src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/Fixtures/xml/listener_undefined_provider.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
http://symfony.com/schema/dic/security
99
https://symfony.com/schema/dic/security/security-1.0.xsd">
1010

11-
<sec:config enable-authenticator-manager="true">
11+
<sec:config>
1212
<sec:providers>
1313
<sec:provider name="default" id="foo" />
1414
</sec:providers>

‎src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/Fixtures/xml/logout_delete_cookies.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
http://symfony.com/schema/dic/security
99
https://symfony.com/schema/dic/security/security-1.0.xsd">
1010

11-
<config enable-authenticator-manager="true">
11+
<config>
1212
<provider name="default" id="foo" />
1313

1414
<firewall name="main" provider="default">

‎src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/Fixtures/xml/merge.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
<import resource="merge_import.xml"/>
1313
</imports>
1414

15-
<sec:config enable-authenticator-manager="true">
15+
<sec:config>
1616
<sec:provider name="default" id="foo" />
1717

1818
<sec:firewall name="main" form-login="false">

‎src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/Fixtures/xml/merge_import.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
http://symfony.com/schema/dic/security
99
https://symfony.com/schema/dic/security/security-1.0.xsd">
1010

11-
<config enable-authenticator-manager="true">
11+
<config>
1212
<firewall name="main">
1313
<form-login login-path="/login" />
1414
</firewall>

‎src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/Fixtures/xml/migrating_hasher.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
<import resource="container1.xml"/>
1313
</imports>
1414

15-
<sec:config enable-authenticator-manager="true">
15+
<sec:config>
1616
<sec:password_hasher class="JMS\FooBundle\Entity\User7" algorithm="argon2i" memory-cost="256" time-cost="1">
1717
<sec:migrate-from>bcrypt</sec:migrate-from>
1818
</sec:password_hasher>

0 commit comments

Comments
 (0)
0