8000 minor #27975 [MonologBridge] Improve FirePHPHandler (dunglas) · symfony/symfony@0902337 · GitHub
[go: up one dir, main page]

8000
Skip to content

Commit 0902337

Browse files
committed
minor #27975 [MonologBridge] Improve FirePHPHandler (dunglas)
This PR was merged into the 2.8 branch. Discussion ---------- [MonologBridge] Improve FirePHPHandler | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | no | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets |n/a | License | MIT | Doc PR | n/a Fix a call to a parent static property. Remove a useless call to `getRequest()` Commits ------- 1d93b5e [MonologBridge] Improve FirePHPHandler
2 parents efc4fb3 + 1d93b5e commit 0902337

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

src/Symfony/Bridge/Monolog/Handler/FirePHPHandler.php

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,10 @@ public function onKernelResponse(FilterResponseEvent $event)
3838
return;
3939
}
4040

41-
if (!preg_match('{\bFirePHP/\d+\.\d+\b}', $event->getRequest()->headers->get('User-Agent'))
42-
&& !$event->getRequest()->headers->has('X-FirePHP-Version')) {
43-
$this->sendHeaders = false;
41+
$request = $event->getRequest();
42+
if (!preg_match('{\bFirePHP/\d+\.\d+\b}', $request->headers->get('User-Agent'))
43+
&& !$request->headers->has('X-FirePHP-Version')) {
44+
self::$sendHeaders = false;
4445
$this->headers = array();
4546

4647
return;
@@ -58,7 +59,7 @@ public function onKernelResponse(FilterResponseEvent $event)
5859
*/
5960
protected function sendHeader($header, $content)
6061
{
61-
if (!$this->sendHeaders) {
62+
if (!self::$sendHeaders) {
6263
return;
6364
}
6465

0 commit comments

Comments
 (0)
0