bug #41367 [Ldap] Avoid calling the deprecated getUsername() (derrabus)

chalasr · chalasr · commit 08c80e168887 · 2021-05-21T15:57:59.000+02:00
This PR was merged into the 5.3 branch. Discussion ---------- [Ldap] Avoid calling the deprecated getUsername() | Q | A | ------------- | --- | Branch? | 5.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A Commits ------- 080f81f [Ldap] Avoid calling the deprecated getUsername()
diff --git a/src/Symfony/Component/Ldap/Security/LdapUser.php b/src/Symfony/Component/Ldap/Security/LdapUser.php
@@ -121,7 +121,7 @@ public function isEqualTo(UserInterface $user): bool
             return false;
         }
 
-        if ($this->getUsername() !== $user->getUsername()) {
+        if ($this->getUserIdentifier() !== $user->getUserIdentifier()) {
             return false;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -121,7 +121,7 @@ public function isEqualTo(UserInterface $user): bool`
`121`	`121`	`return false;`
`122`	`122`	`}`
`123`	`123`
`124`		`- if ($this->getUsername() !== $user->getUsername()) {`
	`124`	`+ if ($this->getUserIdentifier() !== $user->getUserIdentifier()) {`
`125`	`125`	`return false;`
`126`	`126`	`}`
`127`	`127`