feature #22828 [Finder] Deprecate FilterIterator (ogizanagi)

nicolas-grekas · nicolas-grekas · commit 08aa6a85821a · 2017-05-21T19:37:44.000+02:00
This PR was merged into the 3.4 branch. Discussion ---------- [Finder] Deprecate FilterIterator | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | no | New feature? | no  | BC breaks? | no | Deprecations? | yes  | Tests pass? | yes | Fixed tickets | #22820 (review) | License | MIT | Doc PR | N/A Commits ------- 946066c [Finder] Deprecate FilterIterator
diff --git a/UPGRADE-3.4.md b/UPGRADE-3.4.md
@@ -1,6 +1,13 @@
 UPGRADE FROM 3.3 to 3.4
 =======================
 
+Finder
+------
+
+ * The `Symfony\Component\Finder\Iterator\FilterIterator` class has been
+   deprecated and will be removed in 4.0 as it used to fix a bug which existed 
+   before version 5.5.23/5.6.7
+
 Validator
 ---------
 
diff --git a/UPGRADE-4.0.md b/UPGRADE-4.0.md
@@ -145,6 +145,8 @@ Finder
 ------
 
  * The `ExceptionInterface` has been removed.
+ * The `Symfony\Component\Finder\Iterator\FilterIterator` class has been
+   removed as it used to fix a bug which existed before version 5.5.23/5.6.7
 
 Form
 ----
diff --git a/src/Symfony/Component/Finder/CHANGELOG.md b/src/Symfony/Component/Finder/CHANGELOG.md
@@ -1,6 +1,11 @@
 CHANGELOG
 =========
 
+3.4.0
+-----
+
+ * deprecated `Symfony\Component\Finder\Iterator\FilterIterator`
+
 3.3.0
 -----
 
diff --git a/src/Symfony/Component/Finder/Iterator/FilterIterator.php b/src/Symfony/Component/Finder/Iterator/FilterIterator.php
@@ -18,6 +18,8 @@
  * @see https://bugs.php.net/68557
  *
  * @author Alex Bogomazov
+ *
+ * @deprecated since 3.4, to be removed in 4.0.
  */
 abstract class FilterIterator extends \FilterIterator
 {
diff --git a/src/Symfony/Component/Finder/Tests/Iterator/FilterIteratorTest.php b/src/Symfony/Component/Finder/Tests/Iterator/FilterIteratorTest.php
@@ -13,6 +13,8 @@
 
 /**
  * @author Alex Bogomazov
+ *
+ * @group legacy
  */
 class FilterIteratorTest extends RealIteratorTestCase
 {

Original file line number	Diff line number	Diff line change
`@@ -18,6 +18,8 @@`
`18`	`18`	`* @see https://bugs.php.net/68557`
`19`	`19`	`*`
`20`	`20`	`* @author Alex Bogomazov`
	`21`	`+ *`
	`22`	`+ * @deprecated since 3.4, to be removed in 4.0.`
`21`	`23`	`*/`
`22`	`24`	`abstract class FilterIterator extends \FilterIterator`
`23`	`25`	`{`
Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,8 @@`
`13`	`13`
`14`	`14`	`/**`
`15`	`15`	`* @author Alex Bogomazov`
	`16`	`+ *`
	`17`	`+ * @group legacy`
`16`	`18`	`*/`
`17`	`19`	`class FilterIteratorTest extends RealIteratorTestCase`
`18`	`20`	`{`