[HttpFoundation] Add create on StreamedResponse

Seldaek · Seldaek · commit 076bd1e99f22 · 2012-03-15T18:40:15.000+01:00
diff --git a/src/Symfony/Component/HttpFoundation/StreamedResponse.php b/src/Symfony/Component/HttpFoundation/StreamedResponse.php
@@ -50,17 +50,25 @@ public function __construct($callback = null, $status = 200, $headers = array())
         $this->streamed = false;
     }
 
+    /**
+     * {@inheritDoc}
+     */
+    public static function create($callback = null, $status = 200, $headers = array())
+    {
+        return new static($callback, $status, $headers);
+    }
+
     /**
      * Sets the PHP callback associated with this Response.
      *
      * @param mixed $callback A valid PHP callback
      */
     public function setCallback($callback)
     {
-        $this->callback = $callback;
-        if (!is_callable($this->callback)) {
+        if (!is_callable($callback)) {
             throw new \LogicException('The Response callback must be a valid PHP callable.');
         }
+        $this->callback = $callback;
     }
 
     /**
diff --git a/tests/Symfony/Tests/Component/HttpFoundation/StreamedResponseTest.php b/tests/Symfony/Tests/Component/HttpFoundation/StreamedResponseTest.php
@@ -86,4 +86,12 @@ public function testGetContent()
         $response = new StreamedResponse(function () { echo 'foo'; });
         $this->assertFalse($response->getContent());
     }
+
+    public function testCreate()
+    {
+        $response = StreamedResponse::create(function () {}, 204);
+
+        $this->assertInstanceOf('Symfony\Component\HttpFoundation\StreamedResponse', $response);
+        $this->assertEquals(204, $response->getStatusCode());
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -50,17 +50,25 @@ public function __construct($callback = null, $status = 200, $headers = array())`
`50`	`50`	`$this->streamed = false;`
`51`	`51`	`}`
`52`	`52`
	`53`	`+ /**`
	`54`	`+ * {@inheritDoc}`
	`55`	`+ */`
	`56`	`+ public static function create($callback = null, $status = 200, $headers = array())`
	`57`	`+ {`
	`58`	`+ return new static($callback, $status, $headers);`
	`59`	`+ }`
	`60`	`+`
`53`	`61`	`/**`
`54`	`62`	`* Sets the PHP callback associated with this Response.`
`55`	`63`	`*`
`56`	`64`	`* @param mixed $callback A valid PHP callback`
`57`	`65`	`*/`
`58`	`66`	`public function setCallback($callback)`
`59`	`67`	`{`
`60`		`- $this->callback = $callback;`
`61`		`- if (!is_callable($this->callback)) {`
	`68`	`+ if (!is_callable($callback)) {`
`62`	`69`	`throw new \LogicException('The Response callback must be a valid PHP callable.');`
`63`	`70`	`}`
	`71`	`+ $this->callback = $callback;`
`64`	`72`	`}`
`65`	`73`
`66`	`74`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -86,4 +86,12 @@ public function testGetContent()`
`86`	`86`	`$response = new StreamedResponse(function () { echo 'foo'; });`
`87`	`87`	`$this->assertFalse($response->getContent());`
`88`	`88`	`}`
	`89`	`+`
	`90`	`+ public function testCreate()`
	`91`	`+ {`
	`92`	`+ $response = StreamedResponse::create(function () {}, 204);`
	`93`	`+`
	`94`	`+ $this->assertInstanceOf('Symfony\Component\HttpFoundation\StreamedResponse', $response);`
	`95`	`+ $this->assertEquals(204, $response->getStatusCode());`
	`96`	`+ }`
`89`	`97`	`}`