add legacy test and class for ScalarSetter with annotation

alexislefebvre · alexislefebvre · commit 06ad95899c4a · 2023-02-13T16:50:59.000+01:00
diff --git a/src/Symfony/Component/DependencyInjection/Tests/Compiler/ResolveBindingsPassTest.php b/src/Symfony/Component/DependencyInjection/Tests/Compiler/ResolveBindingsPassTest.php
@@ -149,12 +149,25 @@ public function testTypedReferenceSupport()
     /**
      * @group legacy
      */
-    public function testScalarSetter()
+    public function testScalarSetterAnnotation()
     {
         $this->expectDeprecation('Since symfony/dependency-injection 6.3: The "@required" annotation on methods is deprecated, use the "Symfony\Contracts\Service\Attribute\Required" attribute instead.');
 
         $container = new ContainerBuilder();
 
+        $definition = $container->autowire('foo', ScalarSetterAnnotation::class);
+        $definition->setBindings(['$defaultLocale' => 'fr']);
+
+        (new AutowireRequiredMethodsPass())->process($container);
+        (new ResolveBindingsPass())->process($container);
+
+        $this->assertEquals([['setDefaultLocale', ['fr']]], $definition->getMethodCalls());
+    }
+
+    public function testScalarSetterAttribute()
+    {
+        $container = new ContainerBuilder();
+
         $definition = $container->autowire('foo', ScalarSetter::class);
         $definition->setBindings(['$defaultLocale' => 'fr']);
 
diff --git a/src/Symfony/Component/DependencyInjection/Tests/Fixtures/includes/autowiring_classes.php b/src/Symfony/Component/DependencyInjection/Tests/Fixtures/includes/autowiring_classes.php
@@ -460,7 +460,7 @@ private function __construct()
 }
 
 // @deprecated since Symfony 6.3, to be removed in 7.0
-class ScalarSetter
+class ScalarSetterAnnotation
 {
     /**
      * @required
@@ -470,6 +470,14 @@ public function setDefaultLocale($defaultLocale)
     }
 }
 
+class ScalarSetter
+{
+    #[Required]
+    public function setDefaultLocale($defaultLocale)
+    {
+    }
+}
+
 interface DecoratorInterface
 {
 }

Original file line number	Diff line number	Diff line change
`@@ -460,7 +460,7 @@ private function __construct()`
`460`	`460`	`}`
`461`	`461`
`462`	`462`	`// @deprecated since Symfony 6.3, to be removed in 7.0`
`463`		`-class ScalarSetter`
	`463`	`+class ScalarSetterAnnotation`
`464`	`464`	`{`
`465`	`465`	`/**`
`466`	`466`	`* @required`
`@@ -470,6 +470,14 @@ public function setDefaultLocale($defaultLocale)`
`470`	`470`	`}`
`471`	`471`	`}`
`472`	`472`
	`473`	`+class ScalarSetter`
	`474`	`+{`
	`475`	`+ #[Required]`
	`476`	`+ public function setDefaultLocale($defaultLocale)`
	`477`	`+ {`
	`478< 5BE2 /code>`	`+ }`
	`479`	`+}`
	`480`	`+`
`473`	`481`	`interface DecoratorInterface`
`474`	`482`	`{`
`475`	`483`	`}`