[Serializer] Improve performance of AbstractObjectDenormalizer with XML/CSV

dunglas · dunglas · commit 06060ffd54ab · 2022-09-17T15:14:51.000+02:00
diff --git a/src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php
@@ -451,7 +451,7 @@ private function validateAndDenormalize(array $types, string $currentClass, stri
                             }
                             break;
                         case Type::BUILTIN_TYPE_INT:
-                            if (ctype_digit($data) || '-' === $data[0] && ctype_digit(substr($data, 1))) {
+                            if (ctype_digit('-' === $data[0] ? substr($data, 1) : $data)) {
                                 $data = (int) $data;
                             } else {
                                 throw NotNormalizableValueException::createForUnexpectedDataType(sprintf('The type of the "%s" attribute for class "%s" must be int ("%s" given).', $attribute, $currentClass, $data), $data, [Type::BUILTIN_TYPE_INT], $context['deserialization_path'] ?? null);

Original file line number	Diff line number	Diff line change
`@@ -451,7 +451,7 @@ private function validateAndDenormalize(array $types, string $currentClass, stri`
`451`	`451`	`}`
`452`	`452`	`break;`
`453`	`453`	`case Type::BUILTIN_TYPE_INT:`
`454`		`- if (ctype_digit($data) \|\| '-' === $data[0] && ctype_digit(substr($data, 1))) {`
	`454`	`+ if (ctype_digit('-' === $data[0] ? substr($data, 1) : $data)) {`
`455`	`455`	`$data = (int) $data;`
`456`	`456`	`} else {`
`457`	`457`	`throw NotNormalizableValueException::createForUnexpectedDataType(sprintf('The type of the "%s" attribute for class "%s" must be int ("%s" given).', $attribute, $currentClass, $data), $data, [Type::BUILTIN_TYPE_INT], $context['deserialization_path'] ?? null);`