8000 review changes · symfony/symfony@05ca8dd · GitHub
[go: up one dir, main page]
Skip to content

Commit 05ca8dd

Browse files
eltharineltharin
committed
review changes
add r to handleR
1 parent 35cc02f commit 05ca8dd

File tree

4 files changed

+12
-12
lines changed

4 files changed

+12
-12
lines changed

‎src/Symfony/Bundle/SecurityBundle/DependencyInjection/MainConfiguration.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
use Symfony\Component\Config\Definition\Exception\InvalidConfigurationException;
2020
use Symfony\Component\Security\Http\EntryPoint\AuthenticationEntryPointInterface;
2121
use Symfony\Component\Security\Http\Session\SessionAuthenticationStrategy;
22-
use Symfony\Component\Security\Http\Authorization\SameAsNotFullFledgedHandle;
22+
use Symfony\Component\Security\Http\Authorization\SameAsNotFullFledgedHandler;
2323

2424
/**
2525
* SecurityExtension configuration structure.
@@ -220,7 +220,7 @@ private function addFirewallsSection(ArrayNodeDefinition $rootNode, array $facto
220220
->ifTrue(fn ($v): bool => $v == 'original')
221221
->then(fn ($v) => null)
222222
->ifTrue(fn ($v): bool => $v == 'same')
223-
->then(fn ($v) => SameAsNotFullFledgedHandle::class)
223+
->then(fn ($v) => SameAsNotFullFledgedHandler::class)
224224
->end()
225225
->end()
226226
->arrayNode('logout')

‎src/Symfony/Bundle/SecurityBundle/Resources/config/security.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
use Symfony\Component\Security\Core\User\MissingUserProvider;
4444
use Symfony\Component\Security\Core\Validator\Constraints\UserPasswordValidator;
4545
use Symfony\Component\Security\Http\Authentication\AuthenticationUtils;
46-
use Symfony\Component\Security\Http\Authorization\SameAsNotFullFledgedHandle;
46+
use Symfony\Component\Security\Http\Authorization\SameAsNotFullFledgedHandler;
4747
use Symfony\Component\Security\Http\Controller\SecurityTokenValueResolver;
4848
use Symfony\Component\Security\Http\Controller\UserValueResolver;
4949
use Symfony\Component\Security\Http\EventListener\IsGrantedAttributeListener;
@@ -316,6 +316,6 @@
316316
->parent('cache.system')
317317
->tag('cache.pool')
318318

319-
->set('security.same_as_not_full_fledged_handle', SameAsNotFullFledgedHandle::class)
319+
->set('security.same_as_not_full_fledged_handle', SameAsNotFullFledgedHandler::class)
320320
;
321321
};

‎src/Symfony/Component/Security/Http/Authorization/SameAsNotFullFledgedHandle.php renamed to ‎src/Symfony/Component/Security/Http/Authorization/SameAsNotFullFledgedHandler.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,13 @@
1919
use Symfony\Component\Security\Core\Exception\AccessDeniedException;
2020

2121
/**
22-
* This is a basic NotFullFledgedHandle
22+
* This is a basic NotFullFledgedHandler
2323
* If IS_AUTHENTICATED_FULLY is in access denied Exception Attrribute, behavior will be as before,
2424
* Otherwise The original AccessDeniedException is throw
2525
*
2626
* @author Roman JOLY <eltharin18@outlook.fr>
2727
*/
28-
class SameAsNotFullFledgedHandle implements NotFullFledgedHandlerInterface
28+
class SameAsNotFullFledgedHandler implements NotFullFledgedHandlerInterface
2929
{
3030
public function handle(Request $request, AccessDeniedException $accessDeniedException, AuthenticationTrustResolverInterface $trustResolver, ?TokenInterface $token, callable $reauthenticateResponse): ?Response
3131
{

‎src/Symfony/Component/Security/Http/Tests/Firewall/ExceptionListenerTest.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
use Symfony\Component\Security\Core\Exception\LogoutException;
2828
use Symfony\Component\Security\Http\Authorization\AccessDeniedHandlerInterface;
2929
use Symfony\Component\Security\Http\Authorization\NotFullFledgedHandlerInterface;
30-
use Symfony\Component\Security\Http\Authorization\SameAsNotFullFledgedHandle;
30+
use Symfony\Component\Security\Http\Authorization\SameAsNotFullFledgedHandler;
3131
use Symfony\Component\Security\Http\EntryPoint\AuthenticationEntryPointInterface;
3232
use Symfony\Component\Security\Http\Firewall\ExceptionListener;
3333
use Symfony\Component\Security\Http\HttpUtils;
@@ -267,7 +267,7 @@ private function createEvent(\Exception $exception, $kernel = null)
267267
return new ExceptionEvent($kernel, Request::create('/'), HttpKernelInterface::MAIN_REQUEST, $exception);
268268
}
269269

270-
private function createExceptionListener(?TokenStorageInterface $tokenStorage = null, ?AuthenticationTrustResolverInterface $trustResolver = null, ?HttpUtils $httpUtils = null, ?AuthenticationEntryPointInterface $authenticationEntryPoint = null, $errorPage = null, ?AccessDeniedHandlerInterface $accessDeniedHandler = null, ?NotFullFledgedHandlerInterface $notFullFledgedHandle = null)
270+
private function createExceptionListener(?TokenStorageInterface $tokenStorage = null, ?AuthenticationTrustResolverInterface $trustResolver = null, ?HttpUtils $httpUtils = null, ?AuthenticationEntryPointInterface $authenticationEntryPoint = null, $errorPage = null, ?AccessDeniedHandlerInterface $accessDeniedHandler = null, ?NotFullFledgedHandlerInterface $notFullFledgedHandler = null)
271271
{
272272
return new ExceptionListener(
273273
$tokenStorage ?? $this->createMock(TokenStorageInterface::class),
@@ -279,15 +279,15 @@ private function createExceptionListener(?TokenStorageInterface $tokenStorage =
279279
$accessDeniedHandler,
280280
null,
281281
false,
282-
$notFullFledgedHandle,
282+
$notFullFledgedHandler,
283283
);
284284
}
285285

286286
private function createNotFullFledgedHandler(?Response $response = null)
287287
{
288-
$entryPoint = $this->createMock(NotFullFledgedHandlerInterface::class);
289-
$entryPoint->method('handle')->willReturn($response);
288+
$handler = $this->createMock(NotFullFledgedHandlerInterface::class);
289+
$handler->method('handle')->willReturn($response);
290290

291-
return $entryPoint;
291+
return $handler;
292292
}
293293
}

0 commit comments

Comments
 (0)
0