8000 [Mime] Relaxing in-reply-to header validation · symfony/symfony@04ddc12 · GitHub
[go: up one dir, main page]

Skip to content

Commit 04ddc12

Browse files
ThomasLandauerfabpot
authored andcommitted
[Mime] Relaxing in-reply-to header validation
1 parent 0558be7 commit 04ddc12

File tree

2 files changed

+16
-2
lines changed

2 files changed

+16
-2
lines changed

src/Symfony/Component/Mime/Header/Headers.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -141,8 +141,8 @@ public function add(HeaderInterface $header): self
141141
'cc' => MailboxListHeader::class,
142142
'bcc' => MailboxListHeader::class,
143143
'message-id' => IdentificationHeader::class,
144-
'in-reply-to' => IdentificationHeader::class,
145-
'references' => IdentificationHeader::class,
144+
'in-reply-to' => UnstructuredHeader::class, // `In-Reply-To` and `References` are less strict than RFC 2822 (3.6.4) to allow users entering the original email's ...
145+
'references' => UnstructuredHeader::class, // ... `Message-ID`, even if that is no valid `msg-id`
146146
'return-path' => PathHeader::class,
147147
];
148148

src/Symfony/Component/Mime/Tests/Header/HeadersTest.php

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -243,4 +243,18 @@ public function testToArray()
243243
"Foo: =?utf-8?Q?aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa?=\r\n =?utf-8?Q?aaaa?=",
244244
], $headers->toArray());
245245
}
246+
247+
public function testInReplyToAcceptsNonIdentifierValues()
248+
{
249+
$headers = new Headers();
250+
$headers->addHeader('In-Reply-To', 'foobar');
251+
$this->assertEquals('foobar', $headers->get('In-Reply-To')->getBody());
252+
}
253+
254+
public function testReferencesAcceptsNonIdentifierValues()
255+
{
256+
$headers = new Headers();
257+
$headers->addHeader('References' , 'foobar');
258+
$this->assertEquals('foobar', $headers->get('References')->getBody());
259+
}
246260
}

0 commit comments

Comments
 (0)
0